Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feedback/v7): Make "required" text for input elements configurable #11287

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Mar 26, 2024

Backport of #11153

From the OP (h/t @soerface):

This introduces an option isRequiredLabel, and I planned to also add errorMessageText.

However, this PR is branched off from a version that is a couple days old. Right now, @c298lee is currently working on getsentry/sentry#63749, which is causing major changes and the current version on master doesn't work yet. Therefore, I didn't yet implement errorMessageText.

So consider this PR as a PoC, and either feel free to tag me when the screenshot changes are done – then I'll redo the changes based on the version that supports screenshots – or add the option on your own; however you prefer 🙂

@billyvg billyvg mentioned this pull request Mar 26, 2024
Copy link
Contributor

github-actions bot commented Mar 26, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.47 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.47 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 75.47 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.1 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.4 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.29 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.52 KB (+0.09% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.53 KB (+0.09% 🔺)
@sentry/browser - Webpack (gzipped) 22.74 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 78.58 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.97 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 35.77 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.17 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.29 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 108.1 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.48 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 38.99 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 71.96 KB (0%)
@sentry/react - Webpack (gzipped) 22.77 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.81 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 53.95 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.3 KB (+0.15% 🔺)

@billyvg billyvg marked this pull request as ready for review March 26, 2024 22:16
@billyvg billyvg requested a review from a team March 26, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants