Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make crashpad the default backend on Linux #927

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

supervacuus
Copy link
Collaborator

We've been discussing this for a year now, and it is a recurring and understandable mental burden for newcomers (as well as developers of integrations within Sentry). From my POV, there is no reason to have breakpad over crashpad as the default backend for Linux besides the worry that we might break builds that rely on that default. Most recent interactions with new users show that people choose crashpad in the end anyway.

I would make this a breaking change toward 0.7.0.

This is also related to the context touched by #908.

I am open to counter-arguments.

@supervacuus supervacuus merged commit 164da79 into master Dec 20, 2023
20 checks passed
@supervacuus supervacuus deleted the build/crashpad_default_on_linux branch December 20, 2023 09:09
@bsergean
Copy link

bsergean commented Mar 6, 2024

fyi when I tried crashpad, it was requiring some extra permissions which aren't always available in kubernetes (like ability to ptrace a process), which is why we are still using breakpad.

but I understand that's it's a more reasonable default, maybe this constraint should be documented somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants