Update Serializer.php #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The long text was clipped incorrectly. An error "Malformed UTF-8 characters, possibly incorrectly encoded" occurs in the method encode in class Raven_Client, when trying to decode the cropped text. Sample text: ``` <p><strong class="h2">Борис Васильев. «Не стреляйте в белых лебедей»</strong><br></p> <p><br></p> <p> Человек и природа – вот основная тема произведения Бориса Васильева «Не стреляйте в белых лебедей».<br></p> <p><br></p> <p> Кто-то, как Егор Полушкин и его сынишка, стараются видеть вокруг красоту и помочь братьям нашим меньшим. А кто-то, как Федор Бурьянов и его сын Вова, смотрят на природу через прицел выгоды.<br></p> <p><br></p> <p> Вот из-за таких людей осталось от местного озера только название – «Лебяжье», а когда-то здесь действительно обитали лебеди. Егор Полушкин, поехав на рынок, покупает прекрасных белых лебедей для озера, чтобы возродить его красоту.<br></p> <p><br></p> <p> Но если для Егора лебеди - это красота, то для жителей деревни – только гастрономический изыск. <br></p> <p><br></p> <p> Беззаветно служа природе, Егор Полушкин отдает ей все, даже свою жизнь. Он не выдал своих обидчиков, наверное, в тайне надеясь на дальнейшее их исправление.<br></p> <p><br></p> <attach-media class="center" data-type="images" data-position="1"></attach-media> <p><br></p> ```
stayallive
previously approved these changes
Feb 21, 2018
|
Thanks for the contribution @truechudo ! Can you add a test to avoid regressing on this bug? Thanks! |
# Conflicts: # lib/Raven/Serializer.php
|
@truechudo I hope you won't mind I added the test for you 😄 It looks like Not sure why yet... since those function are around since PHP 4 and there is no documentation on any internal changes in the docs (http://php.net/manual/en/function.mb-substr.php). |
|
Okay fixed the tests but now it's failing on the memory thing again like in #588. |
|
That error should be solvable increasing the memory limit of that regression test... Let's hope we avoid the same failure under 5.3 afterwards! |
|
Damn, same failure... |
Merged
# Conflicts: # test/Raven/phpt/fatal_reported_with_async.phpt
Jean85
added a commit
that referenced
this pull request
May 4, 2018
Jean85
added a commit
that referenced
this pull request
May 9, 2018
* Fix gzipCompress function name PHP doesn't have `gzipCompress` function, use `gzcompress` instead http://php.net/manual/en/function.gzcompress.php (cherry picked from commit d391712) * Fix notice during tests * Fix Client PHPDoc tag (port of #548 to 2.x) * Added syntax highlighting to README.md (#551) (cherry picked from commit 4dd0a3e) * Add use statement for HttpException class (cherry picked from commit 389c3ac, port of #556 to 2.x) * Change badge with badge poser. (cherry picked from commit 47ce095, port of #557 to 2.x) * Update docs config (cherry picked from commit f9c90cf) * Add test to handle non default port in host (port of #572 to 2.x) * Update changelog with 1.8.4 info (port of #573 to 2.x) * Allow serialization 5 levels deep (port of #554 to 2.x) * Make Serializer string limit customizable (port of #559 to 2.x) * Avoid looping when exception throws exception (port of #587 to 2.x) * Fix monolog handler not accepting Throwable (port of #586 to 2.x) * Fix serializer to account for non-UTF-8 chars (port of #553 to 2.x) * Add 1.9.0 changelog entries (cherry picked from commit 01171cf) * Add timeout and excluded_options config docs (cherry picked from commit 6860a3e) * Add back unrelease heading to changelog (cherry picked from commit 3f52e6f) * Fix CS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long text was clipped incorrectly. An error "Malformed UTF-8 characters, possibly incorrectly encoded" occurs in the method encode in class Raven_Client, when trying to decode the cropped text.
Sample text: