Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to overwrite message limit of 1024 #559

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Make it possible to overwrite message limit of 1024 #559

merged 1 commit into from
Apr 20, 2018

Conversation

brainexe
Copy link
Contributor

@brainexe brainexe commented Mar 6, 2018

Currently the message length limit is fixed to 1024 in the Serializer.
In the Client it's possible to change the value (if needed), but not in serializer context. I just added the possibility to pass higher/lower values.

Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍 thanks!

@stayallive stayallive requested a review from Jean85 April 20, 2018 15:51
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked this against Sentry's limits and LGTM! 👍

@Jean85 Jean85 merged commit b2b6a4e into getsentry:master Apr 20, 2018
@ezintz
Copy link
Contributor

ezintz commented Apr 25, 2018

I guess that the consturctor of the Raven_Client should make use of it, no?

@Jean85 Jean85 mentioned this pull request May 3, 2018
27 tasks
Jean85 added a commit that referenced this pull request May 9, 2018
* Fix gzipCompress function name

PHP doesn't have `gzipCompress` function, use `gzcompress` instead
http://php.net/manual/en/function.gzcompress.php

(cherry picked from commit d391712)

* Fix notice during tests

* Fix Client PHPDoc tag (port of #548 to 2.x)

* Added syntax highlighting to README.md (#551)

(cherry picked from commit 4dd0a3e)

* Add use statement for HttpException class

(cherry picked from commit 389c3ac, port of #556 to 2.x)

* Change badge with badge poser.

(cherry picked from commit 47ce095, port of #557 to 2.x)

* Update docs config

(cherry picked from commit f9c90cf)

* Add test to handle non default port in host (port of #572 to 2.x)

* Update changelog with 1.8.4 info (port of #573 to 2.x)

* Allow serialization 5 levels deep (port of #554 to 2.x)

* Make Serializer string limit customizable (port of #559 to 2.x)

* Avoid looping when exception throws exception (port of #587 to 2.x)

* Fix monolog handler not accepting Throwable (port of #586 to 2.x)

* Fix serializer to account for non-UTF-8 chars (port of #553 to 2.x)

* Add 1.9.0 changelog entries

(cherry picked from commit 01171cf)

* Add timeout and excluded_options config docs

(cherry picked from commit 6860a3e)

* Add back unrelease heading to changelog

(cherry picked from commit 3f52e6f)

* Fix CS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants