Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change badges with badge poser. #557

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Change badges with badge poser. #557

merged 1 commit into from
Feb 26, 2018

Conversation

JellyBellyDev
Copy link

I change the badges "Total Downloads", "Monthly Downloads", "Latest Stable Version" and "License" with badge poser: https://poser.pugx.org/
you like it? :)

@stayallive
Copy link
Collaborator

Hey Andrea!

The only change I am seeing is that these are a bit more exact... any more benefits?

Otherwise I am nog seeing why they should be changed to be honest.

@JellyBellyDev
Copy link
Author

JellyBellyDev commented Feb 26, 2018

Hi Alex,
thanks for the reply.

In my opinion:

  • the data are more exact
  • use the same layout as trevis and scrutinizer with rounded edges
  • written in php

Mine is just a proposal! ;)

Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use those myself, LGTM! 👍

@stayallive stayallive merged commit 96ff84e into getsentry:master Feb 26, 2018
@Jean85 Jean85 mentioned this pull request May 3, 2018
27 tasks
Jean85 pushed a commit that referenced this pull request May 4, 2018
(cherry picked from commit 47ce095, port of #557 to 2.x)
Jean85 added a commit that referenced this pull request May 9, 2018
* Fix gzipCompress function name

PHP doesn't have `gzipCompress` function, use `gzcompress` instead
http://php.net/manual/en/function.gzcompress.php

(cherry picked from commit d391712)

* Fix notice during tests

* Fix Client PHPDoc tag (port of #548 to 2.x)

* Added syntax highlighting to README.md (#551)

(cherry picked from commit 4dd0a3e)

* Add use statement for HttpException class

(cherry picked from commit 389c3ac, port of #556 to 2.x)

* Change badge with badge poser.

(cherry picked from commit 47ce095, port of #557 to 2.x)

* Update docs config

(cherry picked from commit f9c90cf)

* Add test to handle non default port in host (port of #572 to 2.x)

* Update changelog with 1.8.4 info (port of #573 to 2.x)

* Allow serialization 5 levels deep (port of #554 to 2.x)

* Make Serializer string limit customizable (port of #559 to 2.x)

* Avoid looping when exception throws exception (port of #587 to 2.x)

* Fix monolog handler not accepting Throwable (port of #586 to 2.x)

* Fix serializer to account for non-UTF-8 chars (port of #553 to 2.x)

* Add 1.9.0 changelog entries

(cherry picked from commit 01171cf)

* Add timeout and excluded_options config docs

(cherry picked from commit 6860a3e)

* Add back unrelease heading to changelog

(cherry picked from commit 3f52e6f)

* Fix CS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants