Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the "list references" default window width wider #620

Conversation

sidecut
Copy link

@sidecut sidecut commented Jan 20, 2016

When using remotes (with git-flow especially), the remote reference names
are almost always wordwrapped in the "list references" window because it's
somewhat narrow by default. It's possible to resize it with a mouse,
but it's annoying to have to do this every time, especially on Windows 10,
where the window border seems to be only one (1) pixel wide, thus making
the grabbing of the window border tricky.

@dscho
Copy link
Member

dscho commented Jan 21, 2016

Thanks for your contribution!

Technically, this is not Windows-specific, but I am willing to accept this PR and push it upstream myself. The reasoning is sound, after all. If there are objections from the gitk maintainer or other Git developers, I will let you know here, okay?

In any case, I will need your sign-off first (see https://github.com/git/git/blob/v2.6.2/Documentation/SubmittingPatches#L234-L286 for details).

@sidecut
Copy link
Author

sidecut commented Jan 21, 2016

Thank you. I will sign off and resubmit.

When using remotes (with git-flow especially), the remote reference names
are almost always wordwrapped in the "list references" window because it's
somewhat narrow by default. It's possible to resize it with a mouse,
but it's annoying to have to do this every time, especially on Windows 10,
where the window border seems to be only one (1) pixel wide, thus making
the grabbing of the window border tricky.

Signed-off-by: James J. Raden <james.raden@gmail.com>
@sidecut sidecut force-pushed the sidecut-gitk-list-references-window-width branch from 972df97 to 3456faa Compare January 21, 2016 17:20
@sidecut
Copy link
Author

sidecut commented Jan 21, 2016

I believe it's ready now. I signed off on the commit. I also tweaked the wording as per https://github.com/git/git/blob/v2.6.2/Documentation/SubmittingPatches#L234-L286

I believe it's ready now. FYI, I did a git commit --amend followed by git push -f, but according to http://stackoverflow.com/a/32818657/53107 this is ok for pull requests.

Please forgive my newb status. This is my first github pull request (and hopefully not my last).

@sidecut
Copy link
Author

sidecut commented Jan 21, 2016

dscho,

Thanks for submitting this upstream. My git send-email skills are rusty, so for this patch I'm relying upon your good graces and the training wheels that Github provides. ;)

dscho added a commit that referenced this pull request Feb 23, 2016
…dow-width

Make the "list references" default window width wider
@dscho dscho merged commit 2426be1 into git-for-windows:master Feb 23, 2016
@dscho
Copy link
Member

dscho commented Feb 23, 2016

Thanks, and sorry for the delay!

dscho added a commit that referenced this pull request Feb 23, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit to git-for-windows/build-extra that referenced this pull request Feb 23, 2016
The "list references" window of `gitk` [is now wider by
default](git-for-windows/git#620).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this pull request Mar 15, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Mar 18, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Mar 29, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Apr 4, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Apr 30, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request May 20, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Jun 7, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Jun 9, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Jun 9, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Jun 9, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Jun 9, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Jun 14, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Jul 12, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Jul 16, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Jul 23, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Jul 23, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Jul 23, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Jul 27, 2016
…dow-width

Make the "list references" default window width wider
dscho pushed a commit that referenced this pull request Nov 5, 2016
…dow-width

Make the "list references" default window width wider
dscho pushed a commit that referenced this pull request Nov 9, 2016
…dow-width

Make the "list references" default window width wider
dscho pushed a commit that referenced this pull request Nov 10, 2016
…dow-width

Make the "list references" default window width wider
dscho pushed a commit that referenced this pull request Nov 10, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Nov 11, 2016
…dow-width

Make the "list references" default window width wider
dscho added a commit that referenced this pull request Nov 11, 2016
…dow-width

Make the "list references" default window width wider
dscho pushed a commit that referenced this pull request Nov 11, 2016
…dow-width

Make the "list references" default window width wider
dscho pushed a commit that referenced this pull request Nov 11, 2016
…dow-width

Make the "list references" default window width wider
dscho pushed a commit that referenced this pull request Nov 12, 2016
…dow-width

Make the "list references" default window width wider
dscho pushed a commit that referenced this pull request Nov 13, 2016
…dow-width

Make the "list references" default window width wider
dscho pushed a commit that referenced this pull request Nov 14, 2016
…dow-width

Make the "list references" default window width wider
dscho pushed a commit that referenced this pull request Nov 16, 2016
…dow-width

Make the "list references" default window width wider
dscho pushed a commit that referenced this pull request Nov 17, 2016
…dow-width

Make the "list references" default window width wider
dscho pushed a commit that referenced this pull request Nov 17, 2016
…dow-width

Make the "list references" default window width wider
dscho pushed a commit that referenced this pull request Nov 18, 2016
…dow-width

Make the "list references" default window width wider
benpeart pushed a commit that referenced this pull request Jan 18, 2018
Bring the gvfs/master branch up to date with the v2.10.0.windows.1 tag

Related work items: #246, #677, #675, #665, #156, #305, #159, #726, #620, #443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants