Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSW-792 feat do not burn nft even entire liquidity is removed #175

Merged

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Feb 22, 2024

New

  1. even position is clear(no liquidity, no fee left), do not burn nft

its for interface to show closed position

NO MERGE YET

wait for #173 #174

pool/_GET_no_receiver.gno Outdated Show resolved Hide resolved
notJoon
notJoon previously approved these changes Feb 26, 2024
@r3v4s r3v4s dismissed notJoon’s stale review February 26, 2024 06:38

The merge-base changed after approval.

@r3v4s r3v4s force-pushed the GSW-792-feat-do-not-burn-nft-even-entire-liquidity-is-removed branch from ac5fc20 to 5ab7987 Compare February 26, 2024 06:46
@r3v4s r3v4s marked this pull request as ready for review February 26, 2024 06:46
@r3v4s r3v4s requested a review from notJoon February 26, 2024 06:46
@notJoon notJoon merged commit 928b905 into main Feb 26, 2024
@notJoon notJoon deleted the GSW-792-feat-do-not-burn-nft-even-entire-liquidity-is-removed branch February 26, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wait-other-pr other pr(s) should merge first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants