Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSW-876 feat register token helpers #178

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Feb 23, 2024

New

  1. listing registered grc20 tokens in pool, router, staker
  2. behavior of registering grc20 token requires privileges

Fixed

  1. position.CollectFee was returning 0

NO MERGE YET

wait for #173 #174 #175 #176 #177

@r3v4s r3v4s added the wait-other-pr other pr(s) should merge first label Feb 23, 2024
@r3v4s r3v4s self-assigned this Feb 23, 2024
notJoon
notJoon previously approved these changes Feb 26, 2024
@r3v4s r3v4s dismissed notJoon’s stale review February 26, 2024 06:38

The merge-base changed after approval.

@r3v4s r3v4s force-pushed the GSW-876-feat-register-token-helpers branch from ae69903 to 8c70bab Compare February 26, 2024 06:49
@r3v4s r3v4s marked this pull request as ready for review February 26, 2024 06:49
@r3v4s r3v4s requested a review from notJoon February 26, 2024 06:49
@notJoon notJoon merged commit afd1752 into main Feb 26, 2024
@notJoon notJoon deleted the GSW-876-feat-register-token-helpers branch February 26, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wait-other-pr other pr(s) should merge first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants