GSW-875 feat use compute route logic from uniswap for router to calculate ratio #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 23, 2024
notJoon
reviewed
Feb 26, 2024
Comment on lines
147
to
+148
| uniqueTokenList := []string{} | ||
| poolList := p.PoolGetPoolList() | ||
| poolList := pl.PoolGetPoolList() |
There was a problem hiding this comment.
We don't know the final size of the uniqueTokenList, but using the size of the poolList seems to allow us to set the initial capacity and this will reduce the re-allocations.
+ poolList := pl.PoolGetPoolList()
+ uniqueTokenList := make([]string, 0, len(poolList)*2)
- uniqueTokenList := []string{}
- poolList := pl.PoolGetPoolList()There was a problem hiding this comment.
looks great, but why does initial length requires * 2?
There was a problem hiding this comment.
looks great, but why does initial length requires
* 2?
I simply set it to double because I assumed that since each pool has two tokens (token0, token1), each pool would add up to two unique tokens to the list. However, since this value was not set after exact measurement (or, calibrated), we will need to reevaluate this part later.
r3v4s
force-pushed
the
GSW-875-feat-use-compute-route-logic-from-uniswap-for-router-to-calculate-ratio
branch
from
84563ca
to
182c0ce
Compare
notJoon
approved these changes
Feb 26, 2024
notJoon
deleted the
GSW-875-feat-use-compute-route-logic-from-uniswap-for-router-to-calculate-ratio
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
NO MERGE YET
wait for #173 #174 #175