-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix template error in pull request with deleted head repo #24192
Merged
jolheiser
merged 2 commits into
go-gitea:main
from
brechtvl:fix-pr-error-deleted-head-repo
Apr 19, 2023
Merged
Fix template error in pull request with deleted head repo #24192
jolheiser
merged 2 commits into
go-gitea:main
from
brechtvl:fix-pr-error-deleted-head-repo
Apr 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rendering of Allow Edits from Maintainers did not check if the head repo exists, while other parts of the page handle it gracefully.
delvh
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a backport?
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Apr 18, 2023
Zettat123
approved these changes
Apr 19, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Apr 19, 2023
Good question, I think yes |
wolfogre
approved these changes
Apr 19, 2023
wolfogre
added
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
outdated/backport/v1.19
This PR should be backported to Gitea 1.19
labels
Apr 19, 2023
🤖 🎺 |
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Apr 19, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 19, 2023
…4192) Rendering of Allow Edits from Maintainers did not check if the head repo exists, while other parts of the page handle it gracefully.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 20, 2023
* giteaofficial/main: (26 commits) Make HTML template functions support context (go-gitea#24056) Fix issue attachment handling (go-gitea#24202) Update JS dependencies (go-gitea#24218) Remove most path-based golangci exclusions (go-gitea#24214) [skip ci] Updated translations via Crowdin Fix internal sever error when visiting a PR that bound to the deleted team (go-gitea#24127) Add owner team permission check test (go-gitea#24096) Fix incorrect CORS default values (go-gitea#24206) Add repository counter badge to repository tab (go-gitea#24205) Fix template error in pull request with deleted head repo (go-gitea#24192) Make wiki title supports dashes and improve wiki name related features (go-gitea#24143) Fix Resolve Conversation not working in Conversation view (go-gitea#24191) Vertical widths of containers removed (go-gitea#24184) Don't list root repository on compare page if pulls not allowed (go-gitea#24183) Add unset default project column (go-gitea#23531) Allow adding new files to an empty repo (go-gitea#24164) Add runner check in repo action page (go-gitea#24124) Use same action status svg icons on actions list as on action page (go-gitea#24178) [skip ci] Updated translations via Crowdin fix calReleaseNumCommitsBehind (go-gitea#24148) ... # Conflicts: # templates/repo/wiki/view.tmpl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
outdated/backport/v1.19
This PR should be backported to Gitea 1.19
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering of Allow Edits from Maintainers did not check if the head repo exists, while other parts of the page handle it gracefully.