Fix issue attachment handling #24202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
force-pushed
the
fix-issue-attachment
branch
from
ae6d9fb
to
67b353a
Compare
silverwind
reviewed
Apr 19, 2023
GiteaBot
added
the
lgtm/need 2
|
@kdumontnu can you try this? |
silverwind
approved these changes
Apr 19, 2023
GiteaBot
added
lgtm/need 1
kdumontnu
approved these changes
Apr 19, 2023
GiteaBot
added
lgtm/done
Won't cleanly merge on 1.19, up to @wxiaoguang. |
silverwind
added
the
reviewed/wait-merge
silverwind
removed
the
reviewed/wait-merge
|
Unresolved comment above. |
Since it is a bug, I can make a separate PR for 1.19, and test it manually. Update: see Fix issue attachment handling (for 1.19) #24221 |
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
that referenced
this pull request
Apr 20, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 20, 2023
* giteaofficial/main: (26 commits) Make HTML template functions support context (go-gitea#24056) Fix issue attachment handling (go-gitea#24202) Update JS dependencies (go-gitea#24218) Remove most path-based golangci exclusions (go-gitea#24214) [skip ci] Updated translations via Crowdin Fix internal sever error when visiting a PR that bound to the deleted team (go-gitea#24127) Add owner team permission check test (go-gitea#24096) Fix incorrect CORS default values (go-gitea#24206) Add repository counter badge to repository tab (go-gitea#24205) Fix template error in pull request with deleted head repo (go-gitea#24192) Make wiki title supports dashes and improve wiki name related features (go-gitea#24143) Fix Resolve Conversation not working in Conversation view (go-gitea#24191) Vertical widths of containers removed (go-gitea#24184) Don't list root repository on compare page if pulls not allowed (go-gitea#24183) Add unset default project column (go-gitea#23531) Allow adding new files to an empty repo (go-gitea#24164) Add runner check in repo action page (go-gitea#24124) Use same action status svg icons on actions list as on action page (go-gitea#24178) [skip ci] Updated translations via Crowdin fix calReleaseNumCommitsBehind (go-gitea#24148) ... # Conflicts: # templates/repo/wiki/view.tmpl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #24195
Some of the changes are taken from my another fix f07b0de in #20147 (although that PR was discarded ....)
The bug is:
removedfileevent correctlyThis PR doesn't intend to refactor the "upload" code to a perfect state (to avoid making the review difficult), so some legacy styles are kept.