Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JS dependencies #24218

Merged
merged 10 commits into from
Apr 20, 2023
Merged

Update JS dependencies #24218

merged 10 commits into from
Apr 20, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 19, 2023 •
edited
Loading

  • Update all js dependencies, update playwright image to jammy
  • Adjust eslint and vitest config
  • Tested build, monaco, mermaid, katex

@silverwind
Update JS dependencies
0c4db5e 
- Update all js dependencies
- Adjust eslint and vitest config
- Tested build, monaco, mermaid, katex
@silverwind silverwind added this to the 1.20.0 milestone Apr 19, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 19, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 19, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 19, 2023
@silverwind silverwind enabled auto-merge (squash) April 19, 2023 20:12
@silverwind
Copy link
Member Author

Some weird crash on E2E test, will revert to focal if it re-occurs.

=== TestE2e/example.test.e2e (/drone/src/tests/e2e/utils_e2e_test.go:53)
SIGABRT: abort
PC=0x47acc1 m=0 sigcode=0

techknowlogick
techknowlogick reviewed Apr 19, 2023
View reviewed changes
.drone.yml Outdated
@@ -756,7 +756,7 @@ steps:

# TODO: We should probably build all dependencies into a test image
- name: test-e2e
image: mcr.microsoft.com/playwright:v1.32.1-focal
image: mcr.microsoft.com/playwright:v1.32.3-jammy
commands:
- curl -sLO https://go.dev/dl/go1.20.linux-amd64.tar.gz && tar -C /usr/local -xzf go1.20.linux-amd64.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump this version of go?

Copy link
Member Author

@silverwind silverwind Apr 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, a shame golang does not provide stable download links to latest patch release, but we may be able to do some curl+jq magic with https://go.dev/dl/?mode=json.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not as easy as I had hoped, the json only contains latest two supported versions, no structure to select only 1.20.x.

curl 'https://go.dev/dl/?mode=json' | fx

image

Copy link
Member

@jolheiser jolheiser Apr 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik it (the newest version) should always be the first result, though

Copy link
Member Author

@silverwind silverwind Apr 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but i guess we don't always want latest and assuming we are two versions behind it will fail completely, so this needs a more involved script.

Update to 1.20.3 in 6595fc9.

Copy link
Member Author

@silverwind silverwind Apr 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it dynamic in d5a30a7.

It will now track the latest stable 1.20 version of go with this. I could also make it just always use the highest stable version to make this completely maintenaince-free.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done that, now tracking highest stable.

@silverwind silverwind removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 19, 2023
techknowlogick
techknowlogick approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks <3

@techknowlogick techknowlogick enabled auto-merge (squash) April 20, 2023 02:08
@techknowlogick
Copy link
Member

🤖 🎺

@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 20, 2023
@techknowlogick techknowlogick merged commit 92e07f2 into go-gitea:main Apr 20, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 20, 2023
@silverwind silverwind deleted the deps-49 branch April 20, 2023 04:37
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 20, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
0b7bce9 
* giteaofficial/main: (26 commits)
  Make HTML template functions support context (go-gitea#24056)
  Fix issue attachment handling (go-gitea#24202)
  Update JS dependencies (go-gitea#24218)
  Remove most path-based golangci exclusions (go-gitea#24214)
  [skip ci] Updated translations via Crowdin
  Fix internal sever error when visiting a PR that bound to the deleted team (go-gitea#24127)
  Add owner team permission check test (go-gitea#24096)
  Fix incorrect CORS default values (go-gitea#24206)
  Add repository counter badge to repository tab (go-gitea#24205)
  Fix template error in pull request with deleted head repo (go-gitea#24192)
  Make wiki title supports dashes and improve wiki name related features (go-gitea#24143)
  Fix Resolve Conversation not working in Conversation view (go-gitea#24191)
  Vertical widths of containers removed (go-gitea#24184)
  Don't list root repository on compare page if pulls not allowed (go-gitea#24183)
  Add unset default project column (go-gitea#23531)
  Allow adding new files to an empty repo (go-gitea#24164)
  Add runner check in repo action page (go-gitea#24124)
  Use same action status svg icons on actions list as on action page (go-gitea#24178)
  [skip ci] Updated translations via Crowdin
  fix calReleaseNumCommitsBehind (go-gitea#24148)
  ...

# Conflicts:
#	templates/repo/wiki/view.tmpl
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser left review comments

@delvh delvh delvh approved these changes

@lafriks lafriks lafriks approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @techknowlogick @lafriks @jolheiser @delvh @GiteaBot