Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyframe Missing from Animation (gltf) #58968

Closed
ultramarinebicycle opened this issue Mar 10, 2022 · 9 comments · Fixed by #64132
Closed

Keyframe Missing from Animation (gltf) #58968

ultramarinebicycle opened this issue Mar 10, 2022 · 9 comments · Fixed by #64132

Comments

@ultramarinebicycle
Copy link

Godot version

4.0 Alpha 3

System information

Windows 10, AMD 5600x, Nvidia 3060

Issue description

My animation has 3 keyframes. In Godot, the middle one isn't registering. I'm adding the file so it can be imported in Blender and Godot to see the difference in behaviour.

Steps to reproduce

New Inherited GLB scene. Use animation player, middle keyframe is removed.

Minimal reproduction project

SmallContainer.zip

@timothyqiu
Copy link
Member

Disabling "Optimizer" in the import settings seems solve the issue.

@ultramarinebicycle
Copy link
Author

Yup that seems to solve the issue. Might be worth disabling the option by default and putting an "Experimental" warning until root cause is eliminated.

Also for my particular project, there are a zillion keyframes. Is this expected behaviour?

@akien-mga akien-mga added this to the 4.0 milestone Mar 10, 2022
@akien-mga akien-mga moved this to To Assess in 4.x Priority Issues Mar 10, 2022
@timothyqiu
Copy link
Member

Also for my particular project, there are a zillion keyframes. Is this expected behaviour?

It's the result of exporting eased keyframes I believe. The actual values are sampled on export. You'll get the same zillion keyframes if you import the glb back to Blender :)

@ultramarinebicycle
Copy link
Author

Importing this glb file into Blender completely messes up the mesh. And yes, that does have many keyframes as well.
The same mesh problems were visible in the Advanced Importer in Godot but while using it in my project, everything was okay. Not sure what is going on.

@TokageItLab
Copy link
Member

TokageItLab commented Mar 10, 2022

Yes, the optimizer obviously produces odd animations. I agree with disabling it by default. I remember someone might have mentioned that the judgment may be broken about the optimizer's rotation threshold, @fire or @reduz?

@fire
Copy link
Member

fire commented Mar 10, 2022

We have a newer compression system that uses bitpacking, its more reliable. Check it.

@Rodeo-McCabe
Copy link

We have a newer compression system that uses bitpacking, its more reliable. Check it.

Is this just the Compression option in the advanced import dialog? Is it supposed to supersede the optimizer, or can they (theoretically) be used together?

@fire
Copy link
Member

fire commented Mar 10, 2022

They can be used together except when keyframes are missing because they're optimized.

@fire
Copy link
Member

fire commented Apr 16, 2022

Is this resolved? Do you require expanded documentation to be written?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment