-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve blurred content of embedded windows #97745
Improve blurred content of embedded windows #97745
Conversation
In the screenshot, the circles of Test2 and Test3 seem to have become an octagon (the newly introduced white outline probably making it a full circle I'd assume) |
It seems to be a problem caused by |
c328cec
to
7646cfa
Compare
7646cfa
to
4e10173
Compare
335d9b1
to
02bb81e
Compare
The problem of |
No |
Give it a try? |
02bb81e
to
d852dcf
Compare
Hello, It seems that this fix solves #95387, with no side-effect seen so far. |
That's great if there's no problem. |
d852dcf
to
cf64625
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and it greatly reduced blurriness 👍
6a0094f
to
4ec0c32
Compare
ad66cd1
to
eb7b86d
Compare
eb7b86d
to
55e1414
Compare
0bf368d
to
8e7bfff
Compare
cbc9bef
to
c7f9bbf
Compare
Just wondering if there is something wrong with having this pr so it hasn't been merged yet? |
c7f9bbf
to
0bc2c26
Compare
There's nothing wrong a priori, but it needs reviews from maintainers familiar with the Viewport and Window code (such as @bruvzg or @Sauermann). |
Code seems fine, will fully check it tomorrow. |
Thanks! |
Helps: #54030
Helps: #95387
I honestly don't know if I'm doing it the right way, but the issue seems to be forgotten and after a flurry of attempts I'm getting good results.
![图片](https://private-user-images.githubusercontent.com/52148221/372967564-997ef5ff-3d87-4316-a191-bbc2bf9f4d3a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzg5MjQsIm5iZiI6MTczOTMzODYyNCwicGF0aCI6Ii81MjE0ODIyMS8zNzI5Njc1NjQtOTk3ZWY1ZmYtM2Q4Ny00MzE2LWExOTEtYmJjMmJmOWY0ZDNhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA1MzcwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY4NWY3OGI2MWRhZDE3NWMzYzMzMTVkNTkwMGQ4MDk1YWFlNzdiMWVmMTNkZjQzMzBlNzYwOTdlZDkxNjc5NTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.pSdoLSYl43aHrbggphG-26h778lso5ZKJARBL_mSKV4)
![图片](https://private-user-images.githubusercontent.com/52148221/372967880-5f74e24a-7bdb-4036-907e-8a021d6ac72a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzg5MjQsIm5iZiI6MTczOTMzODYyNCwicGF0aCI6Ii81MjE0ODIyMS8zNzI5Njc4ODAtNWY3NGUyNGEtN2JkYi00MDM2LTkwN2UtOGEwMjFkNmFjNzJhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA1MzcwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJkZmZhNGI2YjZiMTNmZTczNWM0M2Q2ZmI0YjBlYWQwZDllNmQ2YTgwYjViMmYyZDg2Mzg2NmVkYzViMzAyODAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ukuR_GgUe0puviLwBI_Y2lBiajTRQf-K0cghHNAIADU)
before:
after:
example:
embedded-window.zip