Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to godot 4.0 #154

Closed
wants to merge 1 commit into from
Closed

Port to godot 4.0 #154

wants to merge 1 commit into from

Conversation

fire
Copy link
Collaborator

@fire fire commented Apr 26, 2023

Fixes: Merging gd4 to master

Fixes: #139

Fix compile error for godot 4.0

Fix reference object constructor

Improve RefCounted binding

Rename ECMAScript to JavaScript for godot 4

Fix compile error with non-editor build

Implement JavaScriptCallable for Signal & slot

Implement script workflow

Godot call javascript is working

[FIX] Failsafe env["TOOLS"] variable getter

[FIX] Fixed missing comma

[FIX] Adds GDNative to GDExtension migration changes

[FIX] Adds missing get_global_name method

Updated JavaScript modules for Godot 4.0 branch
The commits address various issues, such as non-existent files, editor targets, module usage, and compilation errors. The messages also show an effort to align the project's GitHub actions with the main Godot repository and tackle platform-specific problems. Some commits address challenges related to advanced Linux builds and temporarily disable the "-werror" flag due to issues with QuickJS.

Fix compile error for godot 4.0

Fix reference object constructor

Improve RefCounted binding
[ci skip]

Rename ECMAScript to JavaScript for godot 4

Fix compile error with non-editor build

Implement JavaScriptCallable for Signal & slot

Implement script workflow
Godot call javascript is working
[ci skip]

fix typo

[FIX] Failsafe env["TOOLS"] variable getter

[FIX] Fixed missing comma

[FIX] Adds GDNative to GDExtension migration changes

[FIX] Adds missing get_global_name method

Updated JavaScript modules for Godot 4.0 branch
The commits address various issues, such as non-existent files, editor targets, module usage, and compilation errors. The messages also show an effort to align the project's GitHub actions with the main Godot repository and tackle platform-specific problems. Some commits address challenges related to advanced Linux builds and temporarily disable the "-werror" flag due to issues with QuickJS.

Run ./misc/scripts/file_format.sh

Move quickjs to thirdparty.

Update for head guards.

Run black format.

Run ./misc/scripts/mypy_check.sh.

Disable a unit test.

Fix compile errors.

Run `./misc/scripts/clang_format.sh`.

Resource api changed.

Avoid warnings as errors with shadowing.

Missed an override.

Co-Authored-By: Malik Ahmed <animanmaster@gmail.com>
@fire
Copy link
Collaborator Author

fire commented Apr 26, 2023

Waiting for the build to pass.

@fire fire closed this Apr 29, 2023
@fire fire deleted the gd4-merge branch April 29, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge gd4 branch to master Thoughts and comments on moving quickjs to a thirdparty directory?
1 participant