Adds start-aware youtube shortcode #10521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sgharms
force-pushed
the
add-youtube-shortcode-start-offset
branch
from
2bd2cee
to
7bb6392
Compare
|
Thanks for this; Can you push the "sign CLA button" above? |
sgharms
force-pushed
the
add-youtube-shortcode-start-offset
branch
from
7bb6392
to
1fc0b04
Compare
|
@bep CLA signed, code cleaned, additional test added. LMK if there are things to change. |
bep
requested changes
Dec 21, 2022
Additionally, provides an extensible pattern for passing additional query parameters.
sgharms
force-pushed
the
add-youtube-shortcode-start-offset
branch
from
1fc0b04
to
617c956
Compare
|
@septs both of those suggested changes looked good, but it makes it extremely hard to review a specific change with unrelated changes coming in from the side line. |
|
@bep So your suggestion, if I understood it correctly, is to deconstruct this PR into:
Given that I currently have a test failure, maybe that's a better way forward so there's less complexity to review / debug. |
sgharms
added a commit
to sgharms/hugo
that referenced
this pull request
Dec 23, 2022
The construction of the query string relied on a generation method that assumed there would only ever one be parameter (`autoplay`). Adding support for an additional param e.g. `start` requires detecting whether either option was set in the shortcode, delimiting with `&` and various other logic that are captured in `querify`. Move to using `querify` and ship, under separate PR, addition of support for a `start` offset parameter (see: gohugoio#10521).
sgharms
added a commit
to sgharms/hugo
that referenced
this pull request
Dec 23, 2022
It's sometimes nice to begin a video `start`-many seconds from the beginning. Fixes gohugoio#10521.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10520