youtube shortcode: Gen. query string w/ querify #10575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The construction of the query string relied on a generation method that assumed there would only ever one be parameter (`autoplay`). Adding support for an additional param e.g. `start` requires detecting whether either option was set in the shortcode, delimiting with `&` and various other logic that are captured in `querify`. Move to using `querify` and ship, under separate PR, addition of support for a `start` offset parameter (see: gohugoio#10521).
This was referenced Dec 23, 2022
jmooring
added a commit
to jmooring/hugo
that referenced
this pull request
Apr 3, 2024
Changes: - Add query string params for controls, loop, mute, start, and end - Add iframe loading attribute - Obtain default iframe title from YouTube oEmbed API - Fix autoplay feature - Improve readability Closes gohugoio#3694 Closes gohugoio#9213 Closes gohugoio#10520 Closes gohugoio#10575 Closes gohugoio#10576 Co-authored-by: sgharms <sgharms@stevengharms.com>
jmooring
added a commit
to jmooring/hugo
that referenced
this pull request
Apr 3, 2024
Changes: - Add query string params for controls, loop, mute, start, and end - Add iframe loading attribute - Obtain default iframe title from YouTube oEmbed API - Fix autoplay feature - Improve readability Closes gohugoio#3694 Closes gohugoio#9213 Closes gohugoio#10520 Closes gohugoio#10575 Closes gohugoio#10576 Co-authored-by: sgharms <sgharms@stevengharms.com>
jmooring
added a commit
to jmooring/hugo
that referenced
this pull request
Apr 3, 2024
Changes: - Add query string params for controls, loop, mute, start, and end - Add iframe loading attribute - Obtain default iframe title from YouTube oEmbed API - Fix autoplay feature - Improve readability Closes gohugoio#3694 Closes gohugoio#9213 Closes gohugoio#10520 Closes gohugoio#10575 Closes gohugoio#10576 Co-authored-by: sgharms <sgharms@stevengharms.com>
jmooring
added a commit
to jmooring/hugo
that referenced
this pull request
Apr 3, 2024
Changes: - Add query string params for controls, loop, mute, start, and end - Add iframe loading attribute - Obtain default iframe title from YouTube oEmbed API - Fix autoplay feature - Improve readability Closes gohugoio#3694 Closes gohugoio#9213 Closes gohugoio#10520 Closes gohugoio#10575 Closes gohugoio#10576 Co-authored-by: sgharms <sgharms@stevengharms.com>
jmooring
added a commit
to jmooring/hugo
that referenced
this pull request
Apr 3, 2024
Changes: - Add query string params for controls, loop, mute, start, and end - Add iframe loading attribute - Obtain default iframe title from YouTube oEmbed API - Fix autoplay feature - Improve readability Closes gohugoio#3694 Closes gohugoio#9213 Closes gohugoio#10520 Closes gohugoio#10575 Closes gohugoio#10576 Co-authored-by: sgharms <sgharms@stevengharms.com>
jmooring
added a commit
to jmooring/hugo
that referenced
this pull request
Apr 3, 2024
Changes: - Add query string params for controls, loop, mute, start, and end - Add iframe loading attribute - Obtain default iframe title from YouTube oEmbed API - Fix autoplay feature - Improve readability Closes gohugoio#3694 Closes gohugoio#9213 Closes gohugoio#10520 Closes gohugoio#10575 Closes gohugoio#10576 Co-authored-by: sgharms <sgharms@stevengharms.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The construction of the query string relied on a
generation method that assumed there would only
ever one be parameter (
autoplay).Adding support for an additional param e.g.
startrequires detecting whether either optionwas set in the shortcode, delimiting with
&andvarious other logic that are captured in
querify.Move to using
querifyand ship, under separatePR, addition of support for a
startoffsetparameter (see: #10521).