Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for start offset to the internal youtube shortcode #10520

Closed
sgharms opened this issue Dec 10, 2022 · 3 comments · Fixed by #12336
Closed

Add support for start offset to the internal youtube shortcode #10520

sgharms opened this issue Dec 10, 2022 · 3 comments · Fixed by #12336

Comments

@sgharms
Copy link
Contributor

sgharms commented Dec 10, 2022

Sometimes it's useful to scrub ahead in an embedded video from YouTube. The URLs support a start= parameter. Expose that interface? I have a local version of the shortcode that works for me, but this might be useful for others?

Copy link

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@github-actions github-actions bot added the Stale label Jan 24, 2024
@SandaruKasa
Copy link

If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.

The pull requests are ready #10575 & #10576 (and have been for over a year), so there is not much work left to be done.

I, personally, am still interested in seeing this merged, even despite the insistently silent treatment I have received from the maintainer so far.

@github-actions github-actions bot removed the Stale label Jan 28, 2024
jmooring added a commit to jmooring/hugo that referenced this issue Apr 3, 2024
Changes:

- Add query string params for controls, loop, mute, start, and end
- Add iframe loading attribute
- Obtain default iframe title from YouTube oEmbed API
- Fix autoplay feature
- Improve readability

Closes gohugoio#3694
Closes gohugoio#9213
Closes gohugoio#10520
Closes gohugoio#10575
Closes gohugoio#10576

Co-authored-by: sgharms <sgharms@stevengharms.com>
jmooring added a commit to jmooring/hugo that referenced this issue Apr 3, 2024
Changes:

- Add query string params for controls, loop, mute, start, and end
- Add iframe loading attribute
- Obtain default iframe title from YouTube oEmbed API
- Fix autoplay feature
- Improve readability

Closes gohugoio#3694
Closes gohugoio#9213
Closes gohugoio#10520
Closes gohugoio#10575
Closes gohugoio#10576

Co-authored-by: sgharms <sgharms@stevengharms.com>
jmooring added a commit to jmooring/hugo that referenced this issue Apr 3, 2024
Changes:

- Add query string params for controls, loop, mute, start, and end
- Add iframe loading attribute
- Obtain default iframe title from YouTube oEmbed API
- Fix autoplay feature
- Improve readability

Closes gohugoio#3694
Closes gohugoio#9213
Closes gohugoio#10520
Closes gohugoio#10575
Closes gohugoio#10576

Co-authored-by: sgharms <sgharms@stevengharms.com>
jmooring added a commit to jmooring/hugo that referenced this issue Apr 3, 2024
Changes:

- Add query string params for controls, loop, mute, start, and end
- Add iframe loading attribute
- Obtain default iframe title from YouTube oEmbed API
- Fix autoplay feature
- Improve readability

Closes gohugoio#3694
Closes gohugoio#9213
Closes gohugoio#10520
Closes gohugoio#10575
Closes gohugoio#10576

Co-authored-by: sgharms <sgharms@stevengharms.com>
jmooring added a commit to jmooring/hugo that referenced this issue Apr 3, 2024
Changes:

- Add query string params for controls, loop, mute, start, and end
- Add iframe loading attribute
- Obtain default iframe title from YouTube oEmbed API
- Fix autoplay feature
- Improve readability

Closes gohugoio#3694
Closes gohugoio#9213
Closes gohugoio#10520
Closes gohugoio#10575
Closes gohugoio#10576

Co-authored-by: sgharms <sgharms@stevengharms.com>
jmooring added a commit to jmooring/hugo that referenced this issue Apr 3, 2024
Changes:

- Add query string params for controls, loop, mute, start, and end
- Add iframe loading attribute
- Obtain default iframe title from YouTube oEmbed API
- Fix autoplay feature
- Improve readability

Closes gohugoio#3694
Closes gohugoio#9213
Closes gohugoio#10520
Closes gohugoio#10575
Closes gohugoio#10576

Co-authored-by: sgharms <sgharms@stevengharms.com>
@bep bep closed this as completed in 8a0ea12 Apr 4, 2024
@bep bep closed this as completed in #12336 Apr 4, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants