tpl/tplimpl: Improve youtube shortcode #12336
Merged
+150
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmooring
force-pushed
the
improve-youtube-shortcode
branch
3 times, most recently
from
de0a39b
to
98fe179
Compare
Changes: - Add query string params for controls, loop, mute, start, and end - Add iframe loading attribute - Obtain default iframe title from YouTube oEmbed API - Fix autoplay feature - Improve readability Closes gohugoio#3694 Closes gohugoio#9213 Closes gohugoio#10520 Closes gohugoio#10575 Closes gohugoio#10576 Co-authored-by: sgharms <sgharms@stevengharms.com>
jmooring
force-pushed
the
improve-youtube-shortcode
branch
from
98fe179
to
d37c7e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Closes #3694
Closes #9213
Closes #10520
Closes #10575
Closes #10576