Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context on Authenticate func #39

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Add context on Authenticate func #39

merged 2 commits into from
Jan 5, 2021

Conversation

instabledesign
Copy link
Member

@instabledesign instabledesign commented Dec 21, 2020 •
edited
Loading

⚠️ BC Break

type Authenticator interface {
    func Authenticate(Credential) (Credential, error)
}
type AuthenticatorFunc func(Credential) (Credential, error)

BECOME

type Authenticator interface {
    func Authenticate(context.Context, Credential) (Credential, error)
}
type AuthenticatorFunc func(context.Context, Credential) (Credential, error)

qneyrat
qneyrat previously approved these changes Dec 21, 2020
View reviewed changes
rmasclef
rmasclef previously approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@rmasclef rmasclef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful to add a BC Break warning after merging it 👍

@instabledesign
Copy link
Member Author

we can merge BC break on master branch, but we need to create the appropriate release version

@rmasclef
Copy link
Member

rmasclef commented Dec 21, 2020 •
edited
Loading

we can merge BC break on master branch, but we need to create the appropriate release version

yep definitely

@instabledesign instabledesign dismissed stale reviews from rmasclef and qneyrat via 0c65da0 January 5, 2021 08:52
@instabledesign instabledesign changed the base branch from master to v4 January 5, 2021 08:53
@codeclimate
Copy link

codeclimate bot commented Jan 5, 2021

Code Climate has analyzed commit 0c65da0 and detected 0 issues on this pull request.

View more on Code Climate.

@instabledesign
Copy link
Member Author

It seems the best way is to create a v4 branch based on master (update all the import .../v4) and point all new commit/BC break directly on this branch before release the all things

@instabledesign instabledesign merged commit 1cebe65 into v4 Jan 5, 2021
@instabledesign instabledesign deleted the new-authenticate branch January 5, 2021 15:30
instabledesign added a commit that referenced this pull request Feb 9, 2021
@instabledesign
Create v4 (#40)
d36e7fe 
* Create v4

* Add context on Authenticate func (#39)

* Add context on Authenticate func

* fixup test

* Curl exporter (#41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qneyrat qneyrat qneyrat left review comments

@rmasclef rmasclef rmasclef left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@instabledesign @rmasclef @qneyrat