Curl exporter #41
Merged
Curl exporter #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 56f976e and detected 0 issues on this pull request. View more on Code Climate. |
rmasclef
requested changes
Feb 8, 2021
| } | ||
| } | ||
|
|
||
| for h := range req.Header { |
There was a problem hiding this comment.
Maybe handle cookies in another iteratio ? (there are so much options to handle 😨)
rmasclef
approved these changes
Feb 8, 2021
request_listener/curl.go
Outdated
| @@ -9,6 +9,10 @@ import ( | |||
| "strings" | |||
| ) | |||
|
|
|||
| // CurlLogDumper will log the given http.Request | |||
| // it gonna log the request using cli curl command format | |||
There was a problem hiding this comment.
it will log the request using the curl command format
request_listener/curl.go
Outdated
| @@ -9,6 +9,10 @@ import ( | |||
| "strings" | |||
| ) | |||
|
|
|||
| // CurlLogDumper will log the given http.Request | |||
| // it gonna log the request using cli curl command format | |||
| // Caution request header and Body can be heavy!! | |||
There was a problem hiding this comment.
/!\ Caution request header and Body can be heavy !! ?
rmasclef
approved these changes
Feb 8, 2021
rmasclef
reviewed
Feb 8, 2021
| // Pay attention to the dump quantity/weight | ||
| // CurlLogDumper will log the request using the curl command format | ||
| // /!\ Caution request header and Body can be heavy !! | ||
| // Eg tripperware: |
There was a problem hiding this comment.
Maybe add something like this:
You can use this tripperware to only dump the request if dump HTTP Header is present ?
rmasclef
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.