Bump all packages to support Nest 8 #342
Conversation
|
Hi @WonderPanda! Hope you are doing well. I struggle to make the integration tests pass. Due to Thanks! |
|
I was worried that there would be issues with some of the NestJS internal especially stuff to do with ExternalContextCreator. I might have some time to look at this over the holidays but if not it'll be on my list for the beginning of the new year |
|
For now , we can migrate non problematic modules to nest 8 and maybe do a seperate pr for ones with problems @IamBlueSlime |
|
any updates? |
Nothing on my side. Still awaiting the last fix for the RabbitMQ package. |
|
I'll continue checking the upgrade to v8 as soon as i can |
Adds support for multiple channels allowing you to change prefetch count for each and handle messages at different speeds
Make `init` return after channel setup has ran not before.
Added rmq integration test for multiple channels to see if things work as intended.
Fixed yarn.lock conflict, assertQueueErrorHandler is optional and new logger
|
Hi @underfisk, this PR aims to add compatibility to Nest 8, I'm not sure if it is the right place to add features to it :/ |
You're right, all I'm doing is just tweaking some logs that were "false positives" and making sure i wrap everything that is needed to fix the problem with ExternalContextCreator |
|
I found that the reason integration tests aren't passing is because, they don't share the same NestJS instalation. Afaik NestJS now uses class references instead of names (strings) as keys for injecting which is the root cause. NestJS being installed just for integration tests: Other minor issues: Needs to remove async/await here for the test to pass: Requires Hope this can help resolving the issues and pushing a new release. |
improves the import of 3rd party types 365
|
A fix was been issued for the nestjs v8 upgrade, tested everything and nothing was breaking @IamBlueSlime After syncing with @jmcdo29 I've decided to make sure we're going to the latest, there are no breaking changes from v8.0.0 -> 8.2.6 that would impact any |
|
@underfisk hi! Thats good to know! Let me do a last check on the PR and we are good to go :) Nice team work here! |
|
All good for me, I was afraid we weren't doing a peer dependency on Nest, but I was wrong :) |
|
@underfisk @IamBlueSlime I'm running into issues trying to publish the new versions. Its now picking up the integration test lib as an actual package that it wants to try and also publish to NPM. I removed the change to the lerna.json config with #376 but it's still insisting on tryng to include it when I prepare to publish: Changes:
? Are you sure you want to publish these packages? No |
|
Shoudln't you be able to set |
Good call! Lerna still lists it as a change (which is weird since its not included in lerna.json) but it no longer tries to publish it. Looking forward to ditching this old pipeline and having everything automated and moved over to NX. |
This PR moves the support of all the packages to Nest 8.
All packages depending on Nest were bumped to a new major version,
0.x-like packages were bumped to a new minor.Please note that Nest 8 involved a new version of Rxjs. I did my best to match the behavior to deprecated functions, but another eye would be really appreciated!
As Nest needed an updated Typescript version, I've bumped it here. Also bumped the lint packages as they were not handling the new TS version correctly.
Changes:
@nestjs/*packages and has lesser dependencies