Publish CLs from internal repository (CL 87592180 - CL 91370456) #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encoding_util is used only by mozc_tool. Moving it to src/gui/base consolidates build dependencies and improves code portability. This is just a refactoring. No behavior change is intended. BUG=#252 TEST=unittest REF_BUG=19010851 REF_CL=87592180
Historically Output::all_candidate_words field has been omitted only in NaCl mainly because of performance reasons. With this CL, that field is enabled even in NaCl build. To mitigate the impact on performance, this CL also introduces Request::candidates_size_limit field so that clients can change the maximum number of candidates for each conversion request. BUG= TEST=unittest REF_BUG= REF_CL=88403136
Unlinking-file-then-reload doesn't work here because reload fails because the file has already gone. Therefore, we make the storage empty and save it. BUG=#332 TEST=unittest REF_BUG=19940325 REF_CL=90124705
- Add transliterated name for variant type. - Add comment for each type. - Fixed some errors. REF_BUG=19918925 REF_CL=90140131,90388075
This is a preparation to add 3-digit rewriting by parameterizing out constant '4'. BUG= TEST=compile REF_BUG=20059084 REF_CL=90573575
BUG= TEST= REF_BUG= REF_CL=90781361
This CL updates DateRewriter to rewrite 3-digits segments to date and time. 3-digits are splitted in two ways (DDD to D+DD and DD+D). The candidates are organized in the following order: 1. description (date/time) 2. split type (D+DD/DD+D) 3. string format (XX:XX, etc) BUG= TEST=unittest REF_BUG=20059084 REF_CL=90971460
With this CL, EncodingUtil::SJISToUTF8 no longer depends on any platform-dependent API, including iconv and Win32 APIs. Keep in mind that EncodingUtil::SJISToUTF8 is mainly used for importing user dictionary for MS-IME. Hence we want EncodingUtil::SJISToUTF8 to be compatible with the behavior on Windows. This also closes #27 because we no longer depend on iconv. BUG=#27,#252 TEST=unittest REF_BUG=19010851 REF_CL=91370456,107291445
yukawa
added a commit
that referenced
this pull request
Nov 15, 2015
Publish CLs from internal repository (CL 87592180 - CL 91370456)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits corresponds to CLs in Google internal repository from
CL 87592180toCL 91370456.