Merge 'logging-api' branch to master. #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed after review on PR #1488.
- Copyright year -> 2016. - Pubsub -> Logging. - Other formatting issues from @dhermes' review.
Addresses: #1564 (comment)
…otobf Hide 'six' and 'google.protobuf' from pylint's borked import sniffing.
Add 'Logger.log_text' method.
Add 'Logger.log_struct'
Add 'Logger.delete' method.
Add 'Client.list_entries'.
Add 'Logger.list_entries'.
Add 'Sink.create' API wrapper and 'Client.sink' factory.
Add 'Sink.exists' API wrapper.
Add 'Sink.reload' API wrapper.
Labels can be passed in explicitly to the 'log_text', 'log_struct', or 'log_proto' methods. If not passed, any default values configured on the logger instance will be used. See: #1566.
It was needed earlier for batch support, but was masked by the attribute on the mock '_Logger' used by the batch tests.
Support entry labels
Parse from API resource if found.
- insert_id - severity - http_request See: #1566.
…severity_httprequest Add support for logging w/ per-request metadata.
Fixes order-based failure between 'log_struct' and 'log_test'. #1657 still breaks the teardown.
Uses the Bigquery destination because that one runs quickest.
…ing_logger_name Avoid reusing logger name in logging system tests
Add system test for 'Sink.reload'.
Add system test for 'Sink.update'.
…data Add system tests for logging w/ insert_id/severty/http_request metdata.
…ting_logs Add exponential backoff for deletion failures.
…e_pubsub_topic Add system test for 'Sink.create' using a Pubsub topic
googlebot
added
the
cla: yes
|
@tseaver Anything for me to do here? Also, any idea what triggered AppVeyor? |
|
@dhermes I don't think further review is really needed: each of the commits on the branch are the result of reviewed PRs. I know there will be a (small) conflict with your @jgeewax I plan to merge tomorrow, if that doesn't conflict with anything else planned for the day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.