Faster subsequent Rust SDK conformance builds #1122

aLekSer · 2019-10-16T20:28:44Z

Add save-cache target for Rust. Fixed Rust SDK test subsequent call was downloading and rebuilding all dependencies.

agones-bot · 2019-10-16T20:52:49Z

Build Failed 😱

Build Id: 39410f45-e42e-41a4-b4be-715d972f5af7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-10-16T21:04:15Z

Build Failed 😱

Build Id: c31be20a-b775-480a-89d6-00dc1633be94

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-10-16T21:22:42Z

Build Succeeded 👏

Build Id: da07b335-e1e1-45d9-be96-34302d1f4a8e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-d39ad37
image: gcr.io/agones-images/agones-sdk:1.1.0-d39ad37
image: gcr.io/agones-images/agones-ping:1.1.0-d39ad37
Linux C++ SDK (build): agonessdk-1.1.0-d39ad37-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-d39ad37.zip

A preview of the website (the last 30 builds are retained):

https://d39ad37-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1122/head:pr_1122 && git checkout pr_1122
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-d39ad37

agones-bot · 2019-10-16T21:57:56Z

Build Succeeded 👏

Build Id: 24cfff87-7786-4966-a776-d4a6e9193703

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-bd72be0
image: gcr.io/agones-images/agones-sdk:1.1.0-bd72be0
image: gcr.io/agones-images/agones-ping:1.1.0-bd72be0
Linux C++ SDK (build): agonessdk-1.1.0-bd72be0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-bd72be0.zip

A preview of the website (the last 30 builds are retained):

https://bd72be0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1122/head:pr_1122 && git checkout pr_1122
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-bd72be0

aLekSer · 2019-10-16T22:02:12Z

Now second build of Rust SDK Conformance with using restore-cache took 6 seconds:

Step #22 - "sdk-conformance": + cargo build
Step #22 - "sdk-conformance": Compiling agones v0.1.0 (/go/src/agones.dev/agones/sdks/rust)
Step #22 - "sdk-conformance": warning: use of deprecated item 'std::error::Error::cause': replaced by Error::source, which can support downcasting
Step #22 - "sdk-conformance": --> /go/src/agones.dev/agones/sdks/rust/src/errors.rs:16:1
Step #22 - "sdk-conformance": Compiling rust-simple v0.1.0 (/go/src/agones.dev/agones/test/sdk/rust)
Step #22 - "sdk-conformance": warning: variable does not need to be mutable
Step #22 - "sdk-conformance": --> src/main.rs:24:19
[... warning ommitted ] 
Step #24: | [134 files][ 10.4 GiB/ 10.5 GiB] 37.9 MiB/s / / [135 files][ 10.5 GiB/ 10.5 GiB] 39.4 MiB/s - Copying file://agonessdk-1.1.0-519f278-linux-arch_64.tar.gz [Content-Type=application/x-tar]...
Step #22 - "sdk-conformance": Finished dev [unoptimized + debuginfo] target(s) in 6.02s

Previously it takes Finished dev [unoptimized + debuginfo] target(s) in 52.34s without downloading.
Also we become not dependent on availability of crates.io now.

aLekSer · 2019-10-16T22:09:46Z

About 3 minutes are still spent on building docker image each time from scratch:
docker build --tag=agones-build-sdk-rust:dd588212ce /workspace/build/build-sdk-images/rust --build-arg BASE_IMAGE=agones-build-sdk-base:0ea0db43e9 .

So I think we could add gcr.io prefix to the above tag and add these targets here:

agones/build/Makefile

Line 269 in 4c6c07a

    
           push: push-controller-image push-agones-sdk-image push-ping-image push-allocator-image

in order to avoid rebuilding all these additional images.

agones-bot · 2019-10-16T22:34:23Z

Build Succeeded 👏

Build Id: 9861d539-ed2e-4180-832a-a69a889e164a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-3df0b4d
image: gcr.io/agones-images/agones-sdk:1.1.0-3df0b4d
image: gcr.io/agones-images/agones-ping:1.1.0-3df0b4d
Linux C++ SDK (build): agonessdk-1.1.0-3df0b4d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-3df0b4d.zip

A preview of the website (the last 30 builds are retained):

https://3df0b4d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1122/head:pr_1122 && git checkout pr_1122
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-3df0b4d

roberthbailey · 2019-10-18T19:07:00Z

This PR now has conflicts so I can't update it and merge.

aLekSer · 2019-10-18T19:09:01Z

@roberthbailey I will update this branch in an hour time, thanks for reviewing.

roberthbailey · 2019-10-18T19:10:36Z

Excellent. I'm trying to get through a bit of the PR backlog today. :)

agones-bot · 2019-10-18T20:20:47Z

Build Succeeded 👏

Build Id: e177ec74-0b6d-49d6-a243-3a482ad9c05e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-dc2bb39
image: gcr.io/agones-images/agones-sdk:1.1.0-dc2bb39
image: gcr.io/agones-images/agones-ping:1.1.0-dc2bb39
Linux C++ SDK (build): agonessdk-1.1.0-dc2bb39-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-dc2bb39.zip

A preview of the website (the last 30 builds are retained):

https://dc2bb39-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1122/head:pr_1122 && git checkout pr_1122
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-dc2bb39

google-oss-robot · 2019-10-18T20:35:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot added the do-not-merge/work-in-progress label Oct 16, 2019

google-oss-robot requested review from pooneh-m and roberthbailey October 16, 2019 20:28

google-oss-robot added the size/M label Oct 16, 2019

aLekSer force-pushed the rust-sdk-use-cache branch 2 times, most recently from 13b3483 to e1cd6d3 Compare October 16, 2019 20:44

aLekSer force-pushed the rust-sdk-use-cache branch from e1cd6d3 to d39ad37 Compare October 16, 2019 20:58

aLekSer force-pushed the rust-sdk-use-cache branch from d39ad37 to bd72be0 Compare October 16, 2019 21:35

aLekSer force-pushed the rust-sdk-use-cache branch from bd72be0 to 3df0b4d Compare October 16, 2019 22:03

aLekSer marked this pull request as ready for review October 16, 2019 22:04

google-oss-robot removed the do-not-merge/work-in-progress label Oct 16, 2019

Faster subsequent Rust SDK conformance builds

dc2bb39

aLekSer force-pushed the rust-sdk-use-cache branch from 3df0b4d to dc2bb39 Compare October 18, 2019 19:46

roberthbailey approved these changes Oct 18, 2019

View reviewed changes

google-oss-robot assigned roberthbailey Oct 18, 2019

google-oss-robot added the lgtm label Oct 18, 2019

google-oss-robot added the approved label Oct 18, 2019

roberthbailey merged commit 6cff52a into googleforgames:master Oct 18, 2019

roberthbailey mentioned this pull request Oct 22, 2019

Added dynamic configuration of http port in the rust sdk #1125

Merged

markmandel added this to the 1.1.0 milestone Oct 22, 2019

markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc labels Oct 22, 2019

aLekSer mentioned this pull request Oct 24, 2019

CI: Update Rust SDK conformance test cache version #1135

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Faster subsequent Rust SDK conformance builds #1122

Faster subsequent Rust SDK conformance builds #1122

aLekSer commented Oct 16, 2019

agones-bot commented Oct 16, 2019

agones-bot commented Oct 16, 2019

agones-bot commented Oct 16, 2019

agones-bot commented Oct 16, 2019

aLekSer commented Oct 16, 2019

aLekSer commented Oct 16, 2019 •

edited

Loading

agones-bot commented Oct 16, 2019

roberthbailey commented Oct 18, 2019

aLekSer commented Oct 18, 2019 •

edited

Loading

roberthbailey commented Oct 18, 2019

agones-bot commented Oct 18, 2019

google-oss-robot commented Oct 18, 2019

Faster subsequent Rust SDK conformance builds #1122

Faster subsequent Rust SDK conformance builds #1122

Conversation

aLekSer commented Oct 16, 2019

agones-bot commented Oct 16, 2019

agones-bot commented Oct 16, 2019

agones-bot commented Oct 16, 2019

agones-bot commented Oct 16, 2019

aLekSer commented Oct 16, 2019

aLekSer commented Oct 16, 2019 • edited Loading

agones-bot commented Oct 16, 2019

roberthbailey commented Oct 18, 2019

aLekSer commented Oct 18, 2019 • edited Loading

roberthbailey commented Oct 18, 2019

agones-bot commented Oct 18, 2019

google-oss-robot commented Oct 18, 2019

aLekSer commented Oct 16, 2019 •

edited

Loading

aLekSer commented Oct 18, 2019 •

edited

Loading