CI: Update Rust SDK conformance test cache version #1135

aLekSer · 2019-10-22T22:40:37Z

Update cache for Cloud Builds.
As it could be seen from #1125 cloud runs, Rust sdk test downloading dependencies, while it should use cache for that in order to decrease overall CI build.
Fix documentation.

markmandel · 2019-10-22T22:41:51Z

What do you mean by "bringing it back" ? Do you mean clearing it somehow?

aLekSer · 2019-10-22T22:43:08Z

I would update this PR after first test run to make sure that second one is utilising the cache of first run.

aLekSer · 2019-10-22T22:45:36Z

@markmandel I mean that it stops working. It uses only test/sdk/rust/Cargo.toml check sum.
- '--key=$_RUST_SDK_BUILD_CACHE_KEY-$( checksum test/sdk/rust/Cargo.toml )'
So it does not update the cache if key still the same.
That was done intentionally in order not to download all dependencies each time.

agones-bot · 2019-10-22T23:17:41Z

Build Succeeded 👏

Build Id: c385e1ba-aac5-415a-b811-4a699c1885d7

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-a8a89ba
image: gcr.io/agones-images/agones-sdk:1.1.0-a8a89ba
image: gcr.io/agones-images/agones-ping:1.1.0-a8a89ba
Linux C++ SDK (build): agonessdk-1.1.0-a8a89ba-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-a8a89ba.zip

A preview of the website (the last 30 builds are retained):

https://a8a89ba-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1135/head:pr_1135 && git checkout pr_1135
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-a8a89ba

aLekSer · 2019-10-22T23:23:55Z

Triggered one more build with the same save_cache key. New cache should be used.

agones-bot · 2019-10-22T23:59:46Z

Build Succeeded 👏

Build Id: 2dc5efa4-805b-443e-ab78-c00bda6b0903

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-01cb103
image: gcr.io/agones-images/agones-sdk:1.1.0-01cb103
image: gcr.io/agones-images/agones-ping:1.1.0-01cb103
Linux C++ SDK (build): agonessdk-1.1.0-01cb103-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-01cb103.zip

A preview of the website (the last 30 builds are retained):

https://01cb103-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1135/head:pr_1135 && git checkout pr_1135
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-01cb103

aLekSer · 2019-10-23T00:42:18Z

Comparing the results:
Rust build now spent 1 minutes less on second than on a first run.
If not used cache we had (first run):

+ cargo fetch
Updating crates.io index
Downloading crates ...
Downloaded cfg-if v0.1.10
Downloaded futures v0.1.29
Downloaded backtrace v0.3.40
Downloaded backtrace-sys v0.1.32
... [skipped lines]
+ cargo build
Compiling protobuf v2.0.6
Compiling cc v1.0.46
... [skipped lines]
Compiling agones v0.1.0 (/go/src/agones.dev/agones/sdks/rust)

Second run (does not need to perform steps above every time):

+ cargo fetch
Updating crates.io index
+ cargo build
Compiling agones v0.1.0 (/go/src/agones.dev/agones/sdks/rust)

markmandel · 2019-10-23T21:53:17Z

Should we rename this PR to be more indicative of what it's doing?

markmandel · 2019-10-23T21:53:38Z

Or should it be closed - I'm actually not sure what it's doing 😄

aLekSer · 2019-10-24T02:03:27Z

This PR is needed to make Rust builds faster and Rust SDK conformance test now from #1122 don't need to download and compile third party dependencies.
In recent #1125 @roberthbailey requested this update because cargo fetch saw that we have updated Agones Rust SDK and it started to download and compile all other dependencies:

Updating crates.io index
Downloading crates ...
Downloaded cc v1.0.46
...
Compiling agones v0.1.0 (/go/src/agones.dev/agones/sdks/rust)

As it could be seen in these logs:
https://console.cloud.google.com/cloud-build/builds/4b1bf464-c8df-41c8-bb03-c3eb21a1806a?project=agones-images

agones-bot · 2019-10-24T02:10:39Z

Build Succeeded 👏

Build Id: abed07d8-682a-4f19-b1e5-931336848516

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-8de2bd5
image: gcr.io/agones-images/agones-sdk:1.1.0-8de2bd5
image: gcr.io/agones-images/agones-ping:1.1.0-8de2bd5
Linux C++ SDK (build): agonessdk-1.1.0-8de2bd5-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-8de2bd5.zip

A preview of the website (the last 30 builds are retained):

https://8de2bd5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1135/head:pr_1135 && git checkout pr_1135
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-8de2bd5

Need to update the version to trigger `save_cache` in order to avoid downloading third party dependencies.

agones-bot · 2019-10-24T02:37:30Z

Build Succeeded 👏

Build Id: e32273f3-b9c4-4388-845e-02cecb43b7b9

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-42f7203
image: gcr.io/agones-images/agones-sdk:1.1.0-42f7203
image: gcr.io/agones-images/agones-ping:1.1.0-42f7203
Linux C++ SDK (build): agonessdk-1.1.0-42f7203-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-42f7203.zip

A preview of the website (the last 30 builds are retained):

https://42f7203-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1135/head:pr_1135 && git checkout pr_1135
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-42f7203

markmandel · 2019-10-24T22:34:03Z

test/sdk/rust/Cargo.toml

@@ -17,7 +17,7 @@
 # when Rust SDK or Rust test would be updated
 [package]
 name = "rust-simple"
-version = "0.1.0"
+version = "0.2.0"


What is this doing? Why the version increase?

aLekSer · 2019-10-25T04:25:31Z

Hash of this file is used as a key in cloud build cache. After Robert changes #1125 , we got new version. However, as it could be seen from the CI logs, cache was not updated. And I was not able to find a way to make checksum of all files in Rust SDK directory, so I choose this way of forcing cache updates. Since we do not change Rust code very often.

markmandel

Got it! Thanks! Approved!

google-oss-robot · 2019-10-25T18:14:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2019-10-25T18:14:51Z

New changes are detected. LGTM label has been removed.

agones-bot · 2019-10-25T18:27:50Z

Build Succeeded 👏

Build Id: 1e816be5-fa7b-4322-9a18-fdb262363137

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-98bb451
image: gcr.io/agones-images/agones-sdk:1.1.0-98bb451
image: gcr.io/agones-images/agones-ping:1.1.0-98bb451
Linux C++ SDK (build): agonessdk-1.1.0-98bb451-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-98bb451.zip

A preview of the website (the last 30 builds are retained):

https://98bb451-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1135/head:pr_1135 && git checkout pr_1135
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-98bb451

agones-bot · 2019-10-25T18:53:51Z

Build Succeeded 👏

Build Id: 32f88660-e325-4886-8405-661c4674f275

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-abacecb
image: gcr.io/agones-images/agones-sdk:1.1.0-abacecb
image: gcr.io/agones-images/agones-ping:1.1.0-abacecb
Linux C++ SDK (build): agonessdk-1.1.0-abacecb-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-abacecb.zip

A preview of the website (the last 30 builds are retained):

https://abacecb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1135/head:pr_1135 && git checkout pr_1135
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-abacecb

google-oss-robot requested review from EricFortin and markmandel October 22, 2019 22:40

google-oss-robot added the size/XS label Oct 22, 2019

aLekSer changed the title ~~Bump up Rust SDK test version to update cache~~ Bump up Rust SDK test version to update cloud build cache Oct 22, 2019

aLekSer force-pushed the bump-rust-sdk-cache branch from a8a89ba to 01cb103 Compare October 22, 2019 23:23

markmandel added the area/tests Unit tests, e2e tests, anything to make sure things don't break label Oct 23, 2019

aLekSer changed the title ~~Bump up Rust SDK test version to update cloud build cache~~ Update Rust SDK conformance test cache version Oct 24, 2019

aLekSer force-pushed the bump-rust-sdk-cache branch from 01cb103 to 8de2bd5 Compare October 24, 2019 01:57

Update Rust SDK test version for cache update

42f7203

Need to update the version to trigger `save_cache` in order to avoid downloading third party dependencies.

aLekSer force-pushed the bump-rust-sdk-cache branch from 8de2bd5 to 42f7203 Compare October 24, 2019 02:24

aLekSer changed the title ~~Update Rust SDK conformance test cache version~~ CI: Update Rust SDK conformance test cache version Oct 24, 2019

markmandel reviewed Oct 24, 2019

View reviewed changes

markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 25, 2019

markmandel approved these changes Oct 25, 2019

View reviewed changes

google-oss-robot assigned markmandel Oct 25, 2019

google-oss-robot added the lgtm label Oct 25, 2019

google-oss-robot added the approved label Oct 25, 2019

Merge branch 'master' into bump-rust-sdk-cache

98bb451

google-oss-robot removed the lgtm label Oct 25, 2019

Merge branch 'master' into bump-rust-sdk-cache

abacecb

markmandel merged commit 0e244fd into googleforgames:master Oct 25, 2019

markmandel added this to the 1.1.0 milestone Oct 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI: Update Rust SDK conformance test cache version #1135

CI: Update Rust SDK conformance test cache version #1135

aLekSer commented Oct 22, 2019 •

edited

Loading

markmandel commented Oct 22, 2019

aLekSer commented Oct 22, 2019

aLekSer commented Oct 22, 2019 •

edited

Loading

agones-bot commented Oct 22, 2019

aLekSer commented Oct 22, 2019 •

edited

Loading

agones-bot commented Oct 22, 2019

aLekSer commented Oct 23, 2019

markmandel commented Oct 23, 2019

markmandel commented Oct 23, 2019

aLekSer commented Oct 24, 2019 •

edited

Loading

agones-bot commented Oct 24, 2019

agones-bot commented Oct 24, 2019

markmandel Oct 24, 2019

aLekSer commented Oct 25, 2019

markmandel left a comment

google-oss-robot commented Oct 25, 2019

google-oss-robot commented Oct 25, 2019

agones-bot commented Oct 25, 2019

agones-bot commented Oct 25, 2019

CI: Update Rust SDK conformance test cache version #1135

CI: Update Rust SDK conformance test cache version #1135

Conversation

aLekSer commented Oct 22, 2019 • edited Loading

markmandel commented Oct 22, 2019

aLekSer commented Oct 22, 2019

aLekSer commented Oct 22, 2019 • edited Loading

agones-bot commented Oct 22, 2019

aLekSer commented Oct 22, 2019 • edited Loading

agones-bot commented Oct 22, 2019

aLekSer commented Oct 23, 2019

markmandel commented Oct 23, 2019

markmandel commented Oct 23, 2019

aLekSer commented Oct 24, 2019 • edited Loading

agones-bot commented Oct 24, 2019

agones-bot commented Oct 24, 2019

markmandel Oct 24, 2019

Choose a reason for hiding this comment

aLekSer commented Oct 25, 2019

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Oct 25, 2019

google-oss-robot commented Oct 25, 2019

agones-bot commented Oct 25, 2019

agones-bot commented Oct 25, 2019

aLekSer commented Oct 22, 2019 •

edited

Loading

aLekSer commented Oct 22, 2019 •

edited

Loading

aLekSer commented Oct 22, 2019 •

edited

Loading

aLekSer commented Oct 24, 2019 •

edited

Loading