Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite creation of GameServerSets when 1000m CPU limit was used #1188

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Fix infinite creation of GameServerSets when 1000m CPU limit was used #1188

merged 1 commit into from
Nov 21, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Nov 18, 2019 •
edited
Loading

Add Semantic.DeepEqual() to compare equal values autoupdated after
creation, for instance 1000m -> 1 CPU limit.
More accurate comparison of GSSet vs Fleet is used.

Closes #1184.

@aLekSer aLekSer changed the title Fix infinite creating GSSets when 1000m CPU limit Fix infinite creation of GameServerSets when 1000m CPU limit was used Nov 18, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0986090d-c01e-4b70-b0e2-159710f15418

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 55034221-426b-4a8a-bf3f-0001306bfb21

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4547891c-24fa-4058-b6b5-1d31fe7b0ebf

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1188/head:pr_1188 && git checkout pr_1188
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-963a33c

markmandel
markmandel reviewed Nov 20, 2019
View reviewed changes
pkg/fleets/controller.go Outdated
@@ -534,6 +534,42 @@ func (c *Controller) updateFleetStatus(fleet *agonesv1.Fleet) error {
return errors.Wrapf(err, "error updating status of fleet %s", fCopy.ObjectMeta.Name)
}

// equalGameServerTemplates compares template with different Requests and Limits scales
func equalGameServerTemplates(a, b agonesv1.GameServerTemplateSpec) bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like we should be using apiequality.Semantic.DeepEqual, like we do here

(We should probably find other places we use reflect.DeepEquals() and replace those as well.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5a832070-74be-48f5-adc9-4e667ced95b2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Fix infinite creation of GSSets if 1000m cpu used
0abc1be 
Add Semantic.DeepEqual() to compare equal values autoupdated after
creation, for instance 1000m -> 1 CPU limit.
More accurate comparision of GSSet vs Fleet is used.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b8e4ed34-eda9-4553-8b7c-5ee71e288eec

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1188/head:pr_1188 && git checkout pr_1188
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-0abc1be

@aLekSer aLekSer marked this pull request as ready for review November 21, 2019 16:00
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit 9a0bf12 into googleforgames:master Nov 21, 2019
@markmandel markmandel added this to the 1.2.0 milestone Dec 4, 2019
@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. labels Dec 4, 2019
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @ilkercelikyilmaz
Fix infinite creation of GSSets if 1000m cpu used (googleforgames#1188)
fbe2d41 
Add Semantic.DeepEqual() to compare equal values autoupdated after
creation, for instance 1000m -> 1 CPU limit.
More accurate comparision of GSSet vs Fleet is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@markmandel markmandel

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. lgtm size/L
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Agones fails to start the pod after update cpu limits to 1000m
4 participants
@aLekSer @agones-bot @google-oss-robot @markmandel