Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: Remove outdated BoltDB dashboards #11022

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

JoaoBraveCoding
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding commented Oct 25, 2023

What this PR does / why we need it:
This PR removes the dashboards for BoltDB Shipper as they have been replaced by the Index dashboards which we already import

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory.

@JoaoBraveCoding JoaoBraveCoding changed the title operator: Remove outdated BoltDB dashboards as they have been replaced by Index operator: Remove outdated BoltDB dashboards Oct 25, 2023
@JoaoBraveCoding JoaoBraveCoding marked this pull request as ready for review October 25, 2023 09:47
@periklis
Copy link
Collaborator

Do you happen to have a screenshot per before/after case.

@btaani
Copy link
Contributor

btaani commented Oct 25, 2023

lgtm
confirmed on OCP 4.14 console

@JoaoBraveCoding
Copy link
Collaborator Author

Old view:
Screenshot 2023-10-25 at 3 57 48 PM
New view:
Screenshot 2023-10-25 at 4 02 22 PM

@periklis periklis enabled auto-merge (squash) October 26, 2023 13:17
@cstyan
Copy link
Contributor

cstyan commented Nov 16, 2023

I think the merge conflict maybe is blocking the build?

Copy link
Contributor

Trivy scan found the following vulnerabilities:

@periklis periklis merged commit 5535267 into grafana:main Nov 20, 2023
14 checks passed
periklis added a commit to periklis/loki that referenced this pull request Nov 20, 2023
Co-authored-by: Periklis Tsirakidis <periklis@redhat.com>
jeschkies pushed a commit that referenced this pull request Nov 21, 2023
Co-authored-by: Periklis Tsirakidis <periklis@redhat.com>
periklis added a commit to openshift/loki that referenced this pull request Nov 23, 2023
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Co-authored-by: Periklis Tsirakidis <periklis@redhat.com>
@JoaoBraveCoding JoaoBraveCoding deleted the log-4698-v2 branch July 9, 2024 14:31
JoaoBraveCoding added a commit to JoaoBraveCoding/loki that referenced this pull request Oct 23, 2024
BoltDB dashboards had been removed in grafana#11022
however they were renamed which broke our ignore.
See:
grafana#13022
grafana#12788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants