-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: Remove outdated BoltDB dashboards #11022
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoBraveCoding
force-pushed
the
log-4698-v2
branch
from
October 25, 2023 09:46
9064ab5
to
acbc892
Compare
JoaoBraveCoding
changed the title
operator: Remove outdated BoltDB dashboards as they have been replaced by Index
operator: Remove outdated BoltDB dashboards
Oct 25, 2023
JoaoBraveCoding
requested review from
periklis,
xperimental and
a team
as code owners
October 25, 2023 09:47
Do you happen to have a screenshot per before/after case. |
lgtm |
periklis
approved these changes
Oct 26, 2023
I think the merge conflict maybe is blocking the build? |
Trivy scan found the following vulnerabilities:
|
periklis
added a commit
to periklis/loki
that referenced
this pull request
Nov 20, 2023
Co-authored-by: Periklis Tsirakidis <periklis@redhat.com>
jeschkies
pushed a commit
that referenced
this pull request
Nov 21, 2023
Co-authored-by: Periklis Tsirakidis <periklis@redhat.com>
periklis
added a commit
to openshift/loki
that referenced
this pull request
Nov 23, 2023
[release-5.8] Backport PR grafana#11022
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Co-authored-by: Periklis Tsirakidis <periklis@redhat.com>
JoaoBraveCoding
added a commit
to JoaoBraveCoding/loki
that referenced
this pull request
Oct 23, 2024
BoltDB dashboards had been removed in grafana#11022 however they were renamed which broke our ignore. See: grafana#13022 grafana#12788
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes the dashboards for BoltDB Shipper as they have been replaced by the Index dashboards which we already import
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory.