Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(loki-mixin): Fixes for loki-reads dashboard #12788

Merged
merged 1 commit into from
Apr 25, 2024
Merged

chore(loki-mixin): Fixes for loki-reads dashboard #12788

merged 1 commit into from
Apr 25, 2024

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Apr 25, 2024 •
edited
Loading

What this PR does / why we need it:

  • Update HTTP and GRPC routes
  • Add QPS and latency panels for Index Gateway
  • Rename row Index to TSDB Index and BoltDB Shipper to BoltDB Index for consistency

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@chaudum chaudum requested a review from a team as a code owner April 25, 2024 09:10
@chaudum
Fixes for loki-reads dashboard
1f92e93 
* Update HTTP and GRPC routes
* Add QPS and latency panels for Index Gateway
* Rename row `Index` to `TSDB Index` and `BoltDB Shipper` to `BoltDB Index` for
  consistency

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum force-pushed the chaudum/loki-reads-dashboard branch from 723b8b1 to 1f92e93 Compare April 25, 2024 09:12
MichelHollands
MichelHollands approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaudum chaudum merged commit 807d692 into main Apr 25, 2024
58 checks passed
@chaudum chaudum deleted the chaudum/loki-reads-dashboard branch April 25, 2024 16:02
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
JoaoBraveCoding added a commit to JoaoBraveCoding/loki that referenced this pull request Oct 23, 2024
@JoaoBraveCoding
fix(operator): correctly ignore again BlotDB dashboards
e82ccce 
BoltDB dashboards had been removed in grafana#11022
however they were renamed which broke our ignore.
See:
grafana#13022
grafana#12788
@JoaoBraveCoding JoaoBraveCoding mentioned this pull request Oct 23, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaudum @MichelHollands