Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mixins): Align loki-writes mixins with loki-reads #13022

Merged

Conversation

QuentinBisson
Copy link
Contributor

What this PR does / why we need it:

This PR aligns the loki write dashboards with the loki-reads by adding 99p latency where possible, renames the boltdb shipper into bolt db index and do not deploy it for ssd (same as read).

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Signed-off-by: QuentinBisson <quentin@giantswarm.io>
@QuentinBisson QuentinBisson requested a review from a team as a code owner May 23, 2024 12:02
Copy link
Contributor

@cstyan cstyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, deployed these myself locally and they work as expected 👍

@cstyan cstyan merged commit 757b776 into grafana:main Jun 5, 2024
59 checks passed
@QuentinBisson QuentinBisson deleted the add-99-latency-to-loki-writes-dashbaord branch September 19, 2024 12:20
JoaoBraveCoding added a commit to JoaoBraveCoding/loki that referenced this pull request Oct 23, 2024
BoltDB dashboards had been removed in grafana#11022
however they were renamed which broke our ignore.
See:
grafana#13022
grafana#12788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants