Release 145 #5001
Merged
Release 145 #5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add file to CDE (first pass) * Fix bad merge * Fix some todos (still wip) * Support re-saving * Clean up and fix todos * Remove file when CDE is removed * PR feedback (some) * maybe, tentatively, support viewing previously uploaded blobs * Revert "maybe, tentatively, support viewing previously uploaded blobs" This reverts commit 44be811. * Prevent save without submit on file assessments * Actually prevent save * Add todo * Add spec * Make small code style update * Add File to cascade models in utility * Use merge scope Co-authored-by: Elliot <elliot@greenriver.org> * address pr feedback on supports_save_in_progress * Partially address PR feedback * improve comment Co-authored-by: Gig <gig@greenriver.org> * Clarify and add comments * Remove validation * Add test case for duplicate value * Deduplicate identical values * Fix failing spec tests * Fix mistake * Remove deprecated * Fix mistake * Fix spec * Access control check on resubmitted files * Improve code from PR suggestion * Fix test failures (I hope) --------- Co-authored-by: Elliot <elliot@greenriver.org> Co-authored-by: Gig <gig@greenriver.org>
* Break client PII out of client view for OP analytics * Better structure file
* Cleanup for identified SAGE Test issues - APR/CAPER: Q10D, Q16, Q18, Q22C, Q23D, Q23E, Q24A, Q25B, Q25J, Q27H, & Q12 matching Q5a * clean up Q24D - Different Preferred Language * minor updates * missed in last commit
* Captive Portal Updates * minor updates * rubocop
…ng on the user edit screen (#5014)
* WIP; clone report button on APR * Clone reports * Split button and menu; move to application helper * make note of shared infrastructure for reporting
Fix for issues with auth policy for destination clients that reference themselves * Do not use destination client policy unless the client record is within the client data source * Exclude source clients that are also destination clients when delegating permission checks in dest client policy
* Fix bug where ROI records where deleted, keeping only the last batch * Fix bug where ROI records might be left in place after the client record data changed * Improved tests
* Replace CombinePDF with Pdfunite; bump bundle; add pdfunite to the docker image * Remove old gem from gemfile * Helper methods to cleanup Pdfunite block oddity * Make the PDF rendering API a bit more friendly * Typo fix
Adjust source client auth policy for legacy users with windowed data sources and special permissions. Document behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this PR
Description
Release 145