edit ember-can to add additional attribute for namespace #10893

ChaiWithJai · 2021-07-13T12:21:22Z

We wanted the ability to get our namespace from query params
in order to do this, we're using additional attributes via
ember-can to set a bound property directly from our
handlebar file. This sets us up better in the event that
the namespace filter changes on the UI because our handlebar
file will be aware of the change, whereas our ability may not
update as the namespace filter updates.

github-actions · 2021-07-13T12:26:25Z

Ember Asset Size action

As of 65fd437

Files that got Bigger 🚨:

File	raw	gzip
nomad-ui.js	+641 B	+82 B

Files that stayed the same size 🤷‍:

File	raw	gzip
vendor.js	0 B	0 B
nomad-ui.css	0 B	0 B
vendor.css	0 B	0 B

github-actions · 2021-07-13T12:53:12Z

Ember Test Audit comparison

	main	`65fd437`	change
passes	1101	1106	+5
failures	0	0	0
flaky	0	0	0
duration	7m 17s 431ms	7m 46s 036ms	+28s 605ms

We wanted the ability to get our namespace from query params in order to do this, we're using additional attributes via ember-can to set a bound property directly from our handlebar file. This sets us up better in the event that the namespace filter changes on the UI because our handlebar file will be aware of the change, whereas our ability may not update as the namespace filter updates.

github-actions · 2021-07-13T19:47:33Z

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on d92261e:

Acceptance | optimize: lets recommendations be toggled, reports the choices to the recommendations API, and displays task group recommendations serially

ui/app/templates/components/job-version.hbs

ui/tests/acceptance/jobs-list-test.js

ChaiWithJai · 2021-07-19T21:14:06Z

ui/app/controllers/jobs/job/task-group.js

@@ -66,9 +66,10 @@ export default class TaskGroupController extends Controller.extend(
  })
  shouldShowScaleEventTimeline;

-  @computed('model.job.runningDeployment')
+  @computed('model.job.runningDeployment', 'model.job.namespace')


@DingoEatingFuzz I'm getting an error use brace expansion but if write it like:

('model.{job.namespace, job.runningDeployment}')

OR

('model.{namespace, runningDeployment}')

I get Use of undeclared dependencies in computed property. Is that because we're going based on nested keys?

you want a third option:

'model.job.{runningDeployment,namespace}'

Also, it at least used to be the case that spaces after commas in dependent keys would not work.

lgfa29

Great work! Very thorough update on several namespace edge cases.

Some comments, but I think we can move ahead with this. Enabling the Run Job button when * is select would be a nice to have here if it's a quick fix.

lgfa29 · 2021-07-20T14:56:08Z

ui/app/components/task-group-row.js

+  get namespace() {
+    return this.get('taskGroup.job.namespace.name');
+  }


Is this being used? The template is accessing the namespace from the task group directly.

Yes, its used in line 28 below.

Ah thanks! I missed that.

Follow-up question: should this be used in the view then? 😄

Yup, that means that we can clean things up. Great callout.

lgfa29 · 2021-07-20T19:31:11Z

ui/app/templates/jobs/index.hbs

-        {{#if (can "run job")}}
-          <LinkTo @route="jobs.run" data-test-run-job class="button is-primary">Run Job</LinkTo>
+        {{#if (can "run job" namespace=this.qpNamespace)}}
+          <LinkTo @route="jobs.run" @query={{hash namespace=this.qpNamespace}} data-test-run-job class="button is-primary">Run Job</LinkTo>


I can't comment on the ability file, but I think we need to add an extra check to allow running jobs if the wildcard namespace (*) is selected.

For example, a policy like this:

namespace "dev" { policy = "write" }

Should allow the Run Job button to be enabled. If the input job has a namespace that is not dev, then the job submission will fail. But the user should have the ability to at least open the job submit page if the * namespace is selected and their token has a submit-job capability in any namespace.

Buck disagreed with that, I think. Which is why we had this issue: #10545.

Buck's opinions were that routes and views shouldn't be accessible if you don't have permissions. You shouldn't think you can go somewhere that you actually can't and then fail.

But in the example that I gave you do have permission to run jobs in the dev namespace. If you are looking at All (*) namespaces, this includes dev, so you should be able to click on Run Job. Currently the button is disabled.

In job versions, if you have an ACL token with a write policy you should be able to revert a job, however, that was not the case here. This is because we're using ember-can to check if the user can run a job. That permission relies on policiesSupportRunning which uses a function called namespaceIncludesCapability. We're going to need to refactor any cases that use this function.

… component

github-actions · 2022-11-17T02:30:19Z

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

ChaiWithJai linked an issue Jul 13, 2021 that may be closed by this pull request

Nomad UI doesn't detect namespace-specific capabilities #10885

Closed

ChaiWithJai force-pushed the f-ui/namespace-acl-bug branch from d8bef7b to d92261e Compare July 13, 2021 19:14

vercel bot deployed to Preview – nomad-storybook-and-ui July 13, 2021 19:15 View deployment

vercel bot temporarily deployed to Preview – nomad July 13, 2021 19:15 Inactive

ChaiWithJai requested a review from lgfa29 July 13, 2021 19:15

ChaiWithJai marked this pull request as ready for review July 13, 2021 19:15

vercel bot temporarily deployed to Preview – nomad July 14, 2021 20:37 Inactive

vercel bot deployed to Preview – nomad-storybook-and-ui July 14, 2021 20:37 View deployment

DingoEatingFuzz reviewed Jul 14, 2021

View reviewed changes

ui/app/templates/components/job-version.hbs Outdated Show resolved Hide resolved

ChaiWithJai force-pushed the f-ui/namespace-acl-bug branch from 5a5890a to 91f2793 Compare July 15, 2021 13:41

vercel bot temporarily deployed to Preview – nomad July 15, 2021 13:41 Inactive

vercel bot deployed to Preview – nomad-storybook-and-ui July 15, 2021 13:41 View deployment

ChaiWithJai force-pushed the f-ui/namespace-acl-bug branch from 91f2793 to f99a0a8 Compare July 15, 2021 13:43

vercel bot temporarily deployed to Preview – nomad July 15, 2021 13:43 Inactive

vercel bot deployed to Preview – nomad-storybook-and-ui July 15, 2021 13:43 View deployment

ChaiWithJai force-pushed the f-ui/namespace-acl-bug branch from f99a0a8 to 8d45786 Compare July 15, 2021 13:45

vercel bot temporarily deployed to Preview – nomad July 15, 2021 13:45 Inactive

vercel bot deployed to Preview – nomad-storybook-and-ui July 15, 2021 13:46 View deployment

ChaiWithJai force-pushed the f-ui/namespace-acl-bug branch from 8d45786 to f1907e2 Compare July 15, 2021 21:17

vercel bot temporarily deployed to Preview – nomad July 15, 2021 21:17 Inactive

vercel bot deployed to Preview – nomad-storybook-and-ui July 15, 2021 21:17 View deployment

ChaiWithJai commented Jul 15, 2021

View reviewed changes

ui/tests/acceptance/jobs-list-test.js Show resolved Hide resolved

ChaiWithJai force-pushed the f-ui/namespace-acl-bug branch from f1907e2 to 7e7043f Compare July 19, 2021 21:02

vercel bot temporarily deployed to Preview – nomad July 19, 2021 21:02 Inactive

vercel bot deployed to Preview – nomad-storybook-and-ui July 19, 2021 21:02 View deployment

ChaiWithJai commented Jul 19, 2021

View reviewed changes

ChaiWithJai force-pushed the f-ui/namespace-acl-bug branch from 7e7043f to f98fd2f Compare July 19, 2021 21:26

vercel bot temporarily deployed to Preview – nomad July 19, 2021 21:26 Inactive

vercel bot deployed to Preview – nomad-storybook-and-ui July 19, 2021 21:26 View deployment

lgfa29 approved these changes Jul 20, 2021

View reviewed changes

ChaiWithJai force-pushed the f-ui/namespace-acl-bug branch from f98fd2f to b09559e Compare July 20, 2021 20:25

vercel bot deployed to Preview – nomad-storybook-and-ui July 20, 2021 20:25 View deployment

vercel bot temporarily deployed to Preview – nomad July 20, 2021 20:25 Inactive

vercel bot deployed to Preview – nomad-storybook-and-ui July 21, 2021 14:48 View deployment

vercel bot deployed to Preview – nomad July 21, 2021 14:48 View deployment

address merge conflicts

3e07db8

ChaiWithJai force-pushed the f-ui/namespace-acl-bug branch from af8c746 to 3e07db8 Compare July 21, 2021 21:30

vercel bot deployed to Preview – nomad July 21, 2021 21:30 View deployment

vercel bot deployed to Preview – nomad-storybook-and-ui July 21, 2021 21:30 View deployment

ChaiWithJai added 2 commits July 22, 2021 11:43

edit namespace property in handlebar file to use computed property in…

18ddb2d

… component

ui: fixes #10885

65fd437

vercel bot deployed to Preview – nomad-storybook-and-ui July 22, 2021 15:44 View deployment

vercel bot temporarily deployed to Preview – nomad July 22, 2021 15:44 Inactive

ChaiWithJai merged commit 2020737 into main Jul 22, 2021

ChaiWithJai deleted the f-ui/namespace-acl-bug branch July 22, 2021 16:57

notnoop mentioned this pull request Jul 28, 2021

update changelog #10963

Merged

philrenaud mentioned this pull request Jul 8, 2022

[bugfix, ui] Allow running jobs from a namespace-limited token #13659

Merged

github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

edit ember-can to add additional attribute for namespace #10893

edit ember-can to add additional attribute for namespace #10893

ChaiWithJai commented Jul 13, 2021

github-actions bot commented Jul 13, 2021 •

edited

Loading

github-actions bot commented Jul 13, 2021 •

edited

Loading

github-actions bot commented Jul 13, 2021

ChaiWithJai Jul 19, 2021

DingoEatingFuzz Jul 19, 2021

lgfa29 left a comment

lgfa29 Jul 20, 2021

ChaiWithJai Jul 20, 2021

lgfa29 Jul 20, 2021

ChaiWithJai Jul 21, 2021

lgfa29 Jul 20, 2021

ChaiWithJai Jul 20, 2021

lgfa29 Jul 20, 2021

github-actions bot commented Nov 17, 2022

edit ember-can to add additional attribute for namespace #10893

edit ember-can to add additional attribute for namespace #10893

Conversation

ChaiWithJai commented Jul 13, 2021

github-actions bot commented Jul 13, 2021 • edited Loading

Ember Asset Size action

github-actions bot commented Jul 13, 2021 • edited Loading

Ember Test Audit comparison

github-actions bot commented Jul 13, 2021

Ember Test Audit flaky tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgfa29 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 17, 2022

github-actions bot commented Jul 13, 2021 •

edited

Loading

github-actions bot commented Jul 13, 2021 •

edited

Loading