build: upgrade circleci configuration #11889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
force-pushed
the
build-update-circle
branch
from
7947621
to
fe6f6f5
Compare
shoenig
force-pushed
the
build-update-circle
branch
from
fe6f6f5
to
f234097
Compare
This PR upgrades our CI images and fixes some affected tests. - upgrade go-machine-image to premade latest ubuntu LTS (ubuntu-2004:202111-02) - eliminate go-machine-recent-image (no longer necessary) - manage GOPATH in GNUMakefile (see https://discuss.circleci.com/t/gopath-is-set-to-multiple-directories/7174) - fix tcp dial error check (message seems to be OS specific) - spot check values measured instead of specifically 'RSS' (rss no longer reported in cgroups v2) - use safe MkdirTemp for generating tmpfiles NOT applied: (too flakey) - eliminate setting GOMAXPROCS=1 (build tools were also affected by this setting) - upgrade resource type for all imanges to large (2C -> 4C)
shoenig
force-pushed
the
build-update-circle
branch
from
f234097
to
8492c65
Compare
shoenig
commented
Jan 24, 2022
| var files []string | ||
| for i := 1; i < 10; i++ { | ||
| filename := fmt.Sprintf("test%d.txt", i) | ||
| filepath := filepath.Join(os.TempDir(), filename) |
There was a problem hiding this comment.
Conflicts with some other test writing/rm-ing directly in /tmp; at the very least we can make this test use a custom dir
shoenig
changed the title
tgross
approved these changes
Jan 24, 2022
lgfa29
pushed a commit
that referenced
this pull request
Apr 28, 2022
build: upgrade circleci configuration
lgfa29
pushed a commit
that referenced
this pull request
Apr 29, 2022
build: upgrade circleci configuration
This was referenced Apr 29, 2022
lgfa29
added a commit
that referenced
this pull request
Apr 29, 2022
* Merge pull request #11889 from hashicorp/build-update-circle build: upgrade circleci configuration * Merge pull request #12299 from hashicorp/ci-parallel ci: trade test parallelization for unconstrained gomaxprocs * Merge pull request #12321 from hashicorp/ci-less-logging ci: limit gotestsum to circle ci * CI: build binaries for UI branches (#12594) Build binaries for every code change, not just backend code changes. This means that we'll have up-to-date compiled assets for every commit available in CircleCI artifacts. * Merge pull request #12736 from hashicorp/build-update-go-1.17.9 build: update golang to 1.17.9 * cgutil test: reserve only a single CPU for AddAlloc test Reserving the entire machine's worth of CPUs for the `AddAlloc` test triggers a condition where the empty shared CPUs defaults to the parent CPU set on some system configurations. This was done in `main` as part of cgroups v2 work, but we need to backport this to earlier branches in order to use the same machines across branches. Co-authored-by: Seth Hoenig <seth.a.hoenig@gmail.com> Co-authored-by: Tim Gross <tgross@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
Apr 29, 2022
* Merge pull request #11889 from hashicorp/build-update-circle build: upgrade circleci configuration * Merge pull request #12299 from hashicorp/ci-parallel ci: trade test parallelization for unconstrained gomaxprocs * Merge pull request #12321 from hashicorp/ci-less-logging ci: limit gotestsum to circle ci * CI: build binaries for UI branches (#12594) Build binaries for every code change, not just backend code changes. This means that we'll have up-to-date compiled assets for every commit available in CircleCI artifacts. * cgutil test: reserve only a single CPU for AddAlloc test Reserving the entire machine's worth of CPUs for the `AddAlloc` test triggers a condition where the empty shared CPUs defaults to the parent CPU set on some system configurations. This was done in `main` as part of cgroups v2 work, but we need to backport this to earlier branches in order to use the same machines across branches. Co-authored-by: Seth Hoenig <seth.a.hoenig@gmail.com> Co-authored-by: Tim Gross <tgross@hashicorp.com>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades our CI images and fixes some affected tests.
upgrade go-machine-image to premade latest ubuntu LTS (ubuntu-2004:202111-02)
eliminate go-machine-recent-image (no longer necessary)
manage GOPATH in GNUMakefile (see https://discuss.circleci.com/t/gopath-is-set-to-multiple-directories/7174)
fix tcp dial error check (message seems to be OS specific)
spot check values measured instead of specifically 'RSS' (rss no longer reported in cgroups v2)
NOT applied: (too flaky)
These changes cause 1 or 2 random tests to fail consistently. Hard to track down, because it's never the same tests.
eliminate setting
GOMAXPROCS=1(build tools were also affected by this setting)upgrade resource type for all images to large (2C -> 4C)