Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Line charts: explicitly update X-axis whenever xScale changes #14814

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

philrenaud
Copy link
Contributor

Resolves #14808

Previously (for quite awhile perhaps?) the chart line would move above the time x-axis, but the axis itself would never update. While it is cool to rip a hole in space-time via client-side javascript, it's probably better that we scroll the ticks as new x-scale extents update.

Side-note: I am skeptical if the {{did-update this.renderChart}} does anything at all. renderChart() is also called, once removed, from the onInsert modifier-fired action. But I don't think the template modifier triggers at all.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Ember Asset Size action

As of 5826420

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +296 B +34 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Ember Test Audit comparison

main 5826420 change
passes 1423 1423 0
failures 0 0 0
flaky 0 0 0
duration 10m 00s 403ms 10m 31s 334ms +30s 931ms

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.4.x backport to 1.4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timepoints in x-axis graphs
2 participants