UI: Allocation file system explorer #5871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI: Allocation file system explorer: Routing
This lets users navigate the allocation filesystem. It doesn’t support viewing actual files yet.
* master: make purge parameter lowercase (#5895) tr: Fetch Wait channel before killTask in restart
* origin/master: (32 commits) Added additional test cases and fixed go test case update changelog Add Mirage-toggling via environment variable (#5899) changelog: Add entries for windows fixes fifo: Safer access to Conn run post-run/post-stop task runner hooks Fail alloc if alloc runner prestart hooks fail address review comments changelog Missed one revert of backwards compatibility for node drain Improve test cases for detecting content type Undo removal of node drain compat changes Updated with suggestions. fifo: Close connections and cleanup lock handling logmon: Add windows compatibility test client: defensive against getting stale alloc updates Infer content type in alloc fs stat endpoint appveyor: Run logmon tests fifo: Require that fifos do not exist for create vendor: Use dani fork of go-winio ...
I found while working on #5926 that x-icon already adds assertion-compatible selectors, so these wrappers are unnecessary.
When sorting by size, directories are sorted by name, as size isn’t displayed. This includes a change to the positioning of sort arrows for all tables, moving them closer to the text, because in some cases, the arrows for right-aligned columns were ambiguously positioned.
# Conflicts: # ui/app/templates/allocations/allocation/task/index.hbs # ui/app/templates/allocations/allocation/task/logs.hbs
Based on the task-log component. Commonalities will be refactored.
The new streaming-file component takes an arbitrary logger component along with some mode flags and handles things like polling, DOM updates, and scroll position.
It may be an Ember bug: in some circumstances, the ember-transitioning-in class was persisting in table sort links even after the transition completed. This changes the transition animations to be targeted only for breadcrumbs and directory links.
This was causing elements to flow off the page, since the element was assuming 100% but also had a 250px margin for the left column. This had previously been "fixed" by setting overflow-x: auto, but that resulted in tooltips from being clipped. This is a better solution to the same problem.
UI: Alloc FS: File Viewer
UI: Use the standard empty message when an fs dir is empty
DingoEatingFuzz
force-pushed
the
f-ui/alloc-fs
branch
from
4e30f46
to
7b038ac
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a multi-PR project to bring
nomad alloc fsequivalent support to the web UI.