Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting endpoints for autoscaling #4967

Closed
bardielle opened this issue Jun 24, 2018 · 3 comments · Fixed by #4970
Closed

allow setting endpoints for autoscaling #4967

bardielle opened this issue Jun 24, 2018 · 3 comments · Fixed by #4970
Labels
enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Milestone

Comments

@bardielle
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform v1.23.0

Affected Resource(s)

  • website/docs/index.html.markdown
  • provider.go
  • config.go

Terraform Configuration Files

aws-provider.tf file

provider "aws" {
  access_key = "access_key"
  secret_key = "secret_key"

endpoints {
    ec2 = "https://10.0.0.1/api/v2/aws/ec2"
    autoscaling = "https://10.0.0.1/api/v2/aws/asg"
  }

  insecure = "true"
  skip_metadata_api_check = true
  skip_credentials_validation = true
  region = "eu-west-1"
}

N/A

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key: https://keybase.io/hashicorp

Debug Output

sudo ./terraform apply
Error: provider.aws: endpoints.0: invalid or unknown key: autoscaling

Panic Output

N/A

Expected Behavior

Terraform provider should allow users to set autoscaling endpoint

Actual Behavior

Terraform provider doesn't allow users to set autoscaling endpoint

Steps to Reproduce

  1. Set aws-provider autoscaling endpoint
  2. Run terraform apply

Important Factoids

N/A

References

This is a similar bug to
https://github.com/terraform-providers/terraform-provider-aws/pull/2795/files

bardielle added a commit to bardielle/terraform-provider-aws that referenced this issue Jun 24, 2018
Adding support for setting user defined end-point
Github issue hashicorp#4967
bardielle added a commit to bardielle/terraform-provider-aws that referenced this issue Jun 25, 2018
Adding support for setting user defined end-point
Fixes hashicorp#4967
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jun 25, 2018
@bflad bflad added this to the v1.25.0 milestone Jun 25, 2018
@bflad
Copy link
Contributor

bflad commented Jun 25, 2018

This has been merged into master via #4970 and will release with version 1.25.0 of the AWS provider, likely middle of this week. 👍

@bflad
Copy link
Contributor

bflad commented Jun 27, 2018

This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

bflad added a commit that referenced this issue Mar 27, 2019
Historically, we have treated endpoint customization as an optional enhancement when adding service clients to the provider. Over time, the necessity of service endpoint customization has changed including:

* FIPS 140-2 compliant endpoints
* AWS C2S and SC2S potential usage
* AWS Snowball potential usage
* Local testing solutions such as LocalStack
* Rare incorrect default endpoint information provided by the AWS Go SDK

This change enables all existing service clients to support endpoint customization and going forward we can include this support by default. If the AWS Go SDK provides a better customization method in the future or defines environment variable support, we can revisit this in the future. We may also choose to further optimize endpoint handling via new provider configurations (e.g. use all known FIPS 140-2 endpoints).

Endpoint service naming is based on existing configuration. Where we do not have a prior configuration, we opt for using the AWS CLI service naming minus any hyphens. We also deprecate our own naming for `kinesis_analytics` and `r53` with `kinesisanalytics` and `route53` respectively for consistency.

References:

* https://aws.amazon.com/compliance/fips/
* https://aws.amazon.com/federal/us-intelligence-community/
* https://aws.amazon.com/snowball/
* https://docs.aws.amazon.com/cli/latest/index.html
* https://localstack.cloud/
* #7735
* #8007
* #7985
* #4967
* #4670
* #3941
* #3888
* #3608
pull bot pushed a commit to KernelPanicAUS/terraform-provider-aws that referenced this issue Apr 1, 2019
Historically, we have treated endpoint customization as an optional enhancement when adding service clients to the provider. Over time, the necessity of service endpoint customization has changed including:

* FIPS 140-2 compliant endpoints
* AWS C2S and SC2S potential usage
* AWS Snowball potential usage
* Local testing solutions such as LocalStack
* Rare incorrect default endpoint information provided by the AWS Go SDK

This change enables all existing service clients to support endpoint customization and going forward we can include this support by default. If the AWS Go SDK provides a better customization method in the future or defines environment variable support, we can revisit this in the future. We may also choose to further optimize endpoint handling via new provider configurations (e.g. use all known FIPS 140-2 endpoints).

Endpoint service naming is based on existing configuration. Where we do not have a prior configuration, we opt for using the AWS CLI service naming minus any hyphens. We also deprecate our own naming for `kinesis_analytics` and `r53` with `kinesisanalytics` and `route53` respectively for consistency.

References:

* https://aws.amazon.com/compliance/fips/
* https://aws.amazon.com/federal/us-intelligence-community/
* https://aws.amazon.com/snowball/
* https://docs.aws.amazon.com/cli/latest/index.html
* https://localstack.cloud/
* hashicorp#7735
* hashicorp#8007
* hashicorp#7985
* hashicorp#4967
* hashicorp#4670
* hashicorp#3941
* hashicorp#3888
* hashicorp#3608
@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants