Allow overriding firehose and redshift endpoints #8007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/S
CodyHelbling
changed the title
bflad
added
the
enhancement
bflad
approved these changes
Mar 21, 2019
There was a problem hiding this comment.
LGTM, thanks @CodyHelbling 🚀
Output from acceptance testing (provided as a smoke test when unconfigured):
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basic (115.86s)
--- PASS: TestAccAWSRedshiftCluster_basic (501.64s)
bflad
added a commit
that referenced
this pull request
Mar 21, 2019
|
This has been released in version 2.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
bflad
added a commit
that referenced
this pull request
Mar 27, 2019
Historically, we have treated endpoint customization as an optional enhancement when adding service clients to the provider. Over time, the necessity of service endpoint customization has changed including: * FIPS 140-2 compliant endpoints * AWS C2S and SC2S potential usage * AWS Snowball potential usage * Local testing solutions such as LocalStack * Rare incorrect default endpoint information provided by the AWS Go SDK This change enables all existing service clients to support endpoint customization and going forward we can include this support by default. If the AWS Go SDK provides a better customization method in the future or defines environment variable support, we can revisit this in the future. We may also choose to further optimize endpoint handling via new provider configurations (e.g. use all known FIPS 140-2 endpoints). Endpoint service naming is based on existing configuration. Where we do not have a prior configuration, we opt for using the AWS CLI service naming minus any hyphens. We also deprecate our own naming for `kinesis_analytics` and `r53` with `kinesisanalytics` and `route53` respectively for consistency. References: * https://aws.amazon.com/compliance/fips/ * https://aws.amazon.com/federal/us-intelligence-community/ * https://aws.amazon.com/snowball/ * https://docs.aws.amazon.com/cli/latest/index.html * https://localstack.cloud/ * #7735 * #8007 * #7985 * #4967 * #4670 * #3941 * #3888 * #3608
pull bot
pushed a commit
to KernelPanicAUS/terraform-provider-aws
that referenced
this pull request
Apr 1, 2019
Historically, we have treated endpoint customization as an optional enhancement when adding service clients to the provider. Over time, the necessity of service endpoint customization has changed including: * FIPS 140-2 compliant endpoints * AWS C2S and SC2S potential usage * AWS Snowball potential usage * Local testing solutions such as LocalStack * Rare incorrect default endpoint information provided by the AWS Go SDK This change enables all existing service clients to support endpoint customization and going forward we can include this support by default. If the AWS Go SDK provides a better customization method in the future or defines environment variable support, we can revisit this in the future. We may also choose to further optimize endpoint handling via new provider configurations (e.g. use all known FIPS 140-2 endpoints). Endpoint service naming is based on existing configuration. Where we do not have a prior configuration, we opt for using the AWS CLI service naming minus any hyphens. We also deprecate our own naming for `kinesis_analytics` and `r53` with `kinesisanalytics` and `route53` respectively for consistency. References: * https://aws.amazon.com/compliance/fips/ * https://aws.amazon.com/federal/us-intelligence-community/ * https://aws.amazon.com/snowball/ * https://docs.aws.amazon.com/cli/latest/index.html * https://localstack.cloud/ * hashicorp#7735 * hashicorp#8007 * hashicorp#7985 * hashicorp#4967 * hashicorp#4670 * hashicorp#3941 * hashicorp#3888 * hashicorp#3608
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Fixes #7985 - It's related. I'm trying to use this with localstack.
Changes proposed in this pull request:
Output from acceptance testing: