Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for custom Elasticsearch endpoint #3941

Merged
merged 3 commits into from
Mar 27, 2018
Merged

Adding support for custom Elasticsearch endpoint #3941

merged 3 commits into from
Mar 27, 2018

Conversation

jrm16020
Copy link
Contributor

No description provided.

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Mar 27, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. labels Mar 27, 2018
@bflad bflad added this to the v1.13.0 milestone Mar 27, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Mar 27, 2018
@bflad bflad merged commit 0f30604 into hashicorp:master Mar 27, 2018
bflad added a commit that referenced this pull request Mar 27, 2018
@bflad
Copy link
Contributor

bflad commented Mar 29, 2018

This has been released in version 1.13.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

bflad added a commit that referenced this pull request Mar 27, 2019
Historically, we have treated endpoint customization as an optional enhancement when adding service clients to the provider. Over time, the necessity of service endpoint customization has changed including:

* FIPS 140-2 compliant endpoints
* AWS C2S and SC2S potential usage
* AWS Snowball potential usage
* Local testing solutions such as LocalStack
* Rare incorrect default endpoint information provided by the AWS Go SDK

This change enables all existing service clients to support endpoint customization and going forward we can include this support by default. If the AWS Go SDK provides a better customization method in the future or defines environment variable support, we can revisit this in the future. We may also choose to further optimize endpoint handling via new provider configurations (e.g. use all known FIPS 140-2 endpoints).

Endpoint service naming is based on existing configuration. Where we do not have a prior configuration, we opt for using the AWS CLI service naming minus any hyphens. We also deprecate our own naming for `kinesis_analytics` and `r53` with `kinesisanalytics` and `route53` respectively for consistency.

References:

* https://aws.amazon.com/compliance/fips/
* https://aws.amazon.com/federal/us-intelligence-community/
* https://aws.amazon.com/snowball/
* https://docs.aws.amazon.com/cli/latest/index.html
* https://localstack.cloud/
* #7735
* #8007
* #7985
* #4967
* #4670
* #3941
* #3888
* #3608
pull bot pushed a commit to KernelPanicAUS/terraform-provider-aws that referenced this pull request Apr 1, 2019
Historically, we have treated endpoint customization as an optional enhancement when adding service clients to the provider. Over time, the necessity of service endpoint customization has changed including:

* FIPS 140-2 compliant endpoints
* AWS C2S and SC2S potential usage
* AWS Snowball potential usage
* Local testing solutions such as LocalStack
* Rare incorrect default endpoint information provided by the AWS Go SDK

This change enables all existing service clients to support endpoint customization and going forward we can include this support by default. If the AWS Go SDK provides a better customization method in the future or defines environment variable support, we can revisit this in the future. We may also choose to further optimize endpoint handling via new provider configurations (e.g. use all known FIPS 140-2 endpoints).

Endpoint service naming is based on existing configuration. Where we do not have a prior configuration, we opt for using the AWS CLI service naming minus any hyphens. We also deprecate our own naming for `kinesis_analytics` and `r53` with `kinesisanalytics` and `route53` respectively for consistency.

References:

* https://aws.amazon.com/compliance/fips/
* https://aws.amazon.com/federal/us-intelligence-community/
* https://aws.amazon.com/snowball/
* https://docs.aws.amazon.com/cli/latest/index.html
* https://localstack.cloud/
* hashicorp#7735
* hashicorp#8007
* hashicorp#7985
* hashicorp#4967
* hashicorp#4670
* hashicorp#3941
* hashicorp#3888
* hashicorp#3608
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants