keyvaluetags - support Waf Regional #10806
Conversation
|
Thanks for the comments @bflad, it made things much simpler than i intended. |
| @@ -182,8 +187,10 @@ package keyvaluetags | |||
| import ( | |||
| "github.com/aws/aws-sdk-go/aws" | |||
| {{- range .SliceServiceNames }} | |||
| {{- if . | IncludeImport }} | |||
There was a problem hiding this comment.
i had to add this annoying thing is that i had to add a "filter" for imports the the servicetags generation to skip wafregional import as the package itself is not used in this instance
There was a problem hiding this comment.
We can actually remove the custom function with eq 👍
{{- if eq . (. | TagPackage) }}
There was a problem hiding this comment.
Thanks so much for this, @DrFaust92 -- will adjust a few nitpicky things on merge. 🚀
| @@ -182,8 +187,10 @@ package keyvaluetags | |||
| import ( | |||
| "github.com/aws/aws-sdk-go/aws" | |||
| {{- range .SliceServiceNames }} | |||
| {{- if . | IncludeImport }} | |||
There was a problem hiding this comment.
We can actually remove the custom function with eq 👍
{{- if eq . (. | TagPackage) }}| @@ -102,6 +103,7 @@ func main() { | |||
| } | |||
| templateFuncMap := template.FuncMap{ | |||
| "ClientType": keyvaluetags.ServiceClientType, | |||
| "ListTagPackage": keyvaluetags.ServiceTagPackage, | |||
There was a problem hiding this comment.
Will rename to TagPackage for consistency across all generators.
| @@ -110,6 +111,7 @@ func main() { | |||
| } | |||
| templateFuncMap := template.FuncMap{ | |||
| "ClientType": keyvaluetags.ServiceClientType, | |||
| "TagFunctionClass": keyvaluetags.ServiceTagPackage, | |||
There was a problem hiding this comment.
Same here -- will rename to TagPackage for consistency with other generators.
|
This has been released in version 2.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Community Note
Relates #10688
Release note for CHANGELOG: