merge #5
Merged
merge #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aws into mudlark-master
Reference: #9871 Output from acceptance testing: ``` --- PASS: TestAccAWSCloudHsm2Cluster_Tags (281.94s) --- PASS: TestAccAWSCloudHsm2Cluster_basic (286.25s) ```
Includes information how to work with the new `internal/keyvaluetags` generators.
Reference: #7926 Output from acceptance testing: ``` --- PASS: TestAccAWSEcrDataSource_ecrImage (13.77s) --- PASS: TestAccAWSEcrRepository_basic (14.42s) --- PASS: TestAccAWSEcrRepository_immutability (14.53s) --- PASS: TestAccAWSEcrDataSource_ecrRepository (16.21s) --- PASS: TestAccAWSEcrRepository_tags (20.90s) ```
… show tagging on creation versus not, fix typo Reference: #10313
Reference: #7926 In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent `keyvaluetags` handling. Output from acceptance testing: ``` --- PASS: TestAccDataSourceAwsVpc_basic (27.54s) --- PASS: TestAccDataSourceAwsVpc_ipv6Associated (27.56s) --- PASS: TestAccDataSourceAwsVpc_multipleCidr (51.12s) ```
This makes things consistent with #10401 and the AWS documentation.
Examples refer to aws_ses_identity_policy.test. However, the actual resource is called aws_ses_identity_policy.example.
…ad after Create (#10411) Reference: #7926 Similar in nature to: #10315 In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent `keyvaluetags` handling. The previous `setTags()` logic was always performing retries only necessary for resource creation and the resource itself was not following recommended practices to call the Read function after Create. Ouput from acceptance testing: ``` --- PASS: TestAccAWSSubnet_availabilityZoneId (25.22s) --- PASS: TestAccAWSSubnet_basic (25.66s) --- PASS: TestAccAWSSubnet_enableIpv6 (41.83s) --- PASS: TestAccAWSSubnet_ipv6 (66.62s) ```
Reference: #7926 In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent `keyvaluetags` handling. Output from acceptance testing: ``` --- PASS: TestAccDataSourceAwsSubnet_basic (28.82s) --- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock (46.06s) --- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter (46.30s) ```
Reference: #7926 In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent `keyvaluetags` handling. Output from acceptance testing: ``` --- PASS: TestAccDataSourceAwsVpc_basic (27.54s) --- PASS: TestAccDataSourceAwsVpc_ipv6Associated (27.56s) --- PASS: TestAccDataSourceAwsVpc_multipleCidr (51.12s) ```
docs/provider: Add Adding Resource Tagging Support section
…m-hashicorp-terraform-plugin-sdk-1.x Update module hashicorp/terraform-plugin-sdk to v1.2.0
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG:
Output from acceptance testing: