Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge #5

Merged
merged 24 commits into from
Oct 26, 2019
Merged

merge #5

merged 24 commits into from
Oct 26, 2019

Commits on Aug 12, 2019

  1. Configuration menu
    Copy the full SHA
    c1952b4 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2019

  1. Merge branch 'master' of ssh://github.com/mudlark/terraform-provider-…

    …aws into mudlark-master
    bflad committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    6ea4f64 View commit details
    Browse the repository at this point in the history
  2. resource/aws_cloudhsm_v2_cluster: Perform drift detection with tags

    Reference: #9871
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSCloudHsm2Cluster_Tags (281.94s)
    --- PASS: TestAccAWSCloudHsm2Cluster_basic (286.25s)
    ```
    bflad committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    a49859a View commit details
    Browse the repository at this point in the history
  3. docs/provider: Add Adding Resource Tagging Support section

    Includes information how to work with the new `internal/keyvaluetags` generators.
    bflad committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    e5bf34e View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2019

  1. resource/aws_licensemanager_license_configuration: Refactor tagging t…

    …o use keyvaluetags library
    
    Reference: #7052
    Reference: #7926
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSLicenseManagerLicenseConfiguration_basic (12.91s)
    --- PASS: TestAccAWSLicenseManagerLicenseConfiguration_update (20.57s)
    ```
    bflad committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    0f398b1 View commit details
    Browse the repository at this point in the history
  2. service/ecr: Refactor to use keyvaluetags library

    Reference: #7926
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSEcrDataSource_ecrImage (13.77s)
    --- PASS: TestAccAWSEcrRepository_basic (14.42s)
    --- PASS: TestAccAWSEcrRepository_immutability (14.53s)
    --- PASS: TestAccAWSEcrDataSource_ecrRepository (16.21s)
    --- PASS: TestAccAWSEcrRepository_tags (20.90s)
    ```
    bflad committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    b5256fc View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2019

  1. docs/provider: Update Resource Tagging Code Implementation section to…

    … show tagging on creation versus not, fix typo
    
    Reference: #10313
    bflad committed Oct 6, 2019
    Configuration menu
    Copy the full SHA
    a732852 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2019

  1. data-source/aws_vpc: Refactor to use keyvaluetags library

    Reference: #7926
    
    In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent `keyvaluetags` handling.
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccDataSourceAwsVpc_basic (27.54s)
    --- PASS: TestAccDataSourceAwsVpc_ipv6Associated (27.56s)
    --- PASS: TestAccDataSourceAwsVpc_multipleCidr (51.12s)
    ```
    bflad committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    557d865 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2019

  1. Rename Quick Sight in output to QuickSight. (#10603)

    This makes things consistent with
    #10401
    and the AWS documentation.
    mjgpy3 authored and aeschright committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    610e7ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    15cfb0d View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. Fix ses_identity_policy documentation (#10616)

    Examples refer to aws_ses_identity_policy.test. However, the actual
    resource is called aws_ses_identity_policy.example.
    ivanvc authored and aeschright committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    54c6724 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2019

  1. Configuration menu
    Copy the full SHA
    4b29de1 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'mudlark-master'

    bflad committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    fc0e06b View commit details
    Browse the repository at this point in the history
  3. Update CHANGELOG for #10309

    bflad authored Oct 25, 2019
    Configuration menu
    Copy the full SHA
    5155775 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c8236e0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b5aebeb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5bc1de3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    62c6095 View commit details
    Browse the repository at this point in the history
  8. resource/aws_subnet: Refactor to use keyvaluetags library and call Re…

    …ad after Create (#10411)
    
    Reference: #7926
    Similar in nature to: #10315
    
    In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent `keyvaluetags` handling. The previous `setTags()` logic was always performing retries only necessary for resource creation and the resource itself was not following recommended practices to call the Read function after Create.
    
    Ouput from acceptance testing:
    
    ```
    --- PASS: TestAccAWSSubnet_availabilityZoneId (25.22s)
    --- PASS: TestAccAWSSubnet_basic (25.66s)
    --- PASS: TestAccAWSSubnet_enableIpv6 (41.83s)
    --- PASS: TestAccAWSSubnet_ipv6 (66.62s)
    ```
    bflad authored Oct 25, 2019
    Configuration menu
    Copy the full SHA
    f1b17f4 View commit details
    Browse the repository at this point in the history
  9. data-source/aws_subnet: Refactor to use keyvaluetags library (#10412)

    Reference: #7926
    
    In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent `keyvaluetags` handling.
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccDataSourceAwsSubnet_basic (28.82s)
    --- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock (46.06s)
    --- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter (46.30s)
    ```
    bflad authored Oct 25, 2019
    Configuration menu
    Copy the full SHA
    dd2020c View commit details
    Browse the repository at this point in the history
  10. data-source/aws_vpc: Refactor to use keyvaluetags library (#10413)

    Reference: #7926
    
    In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent `keyvaluetags` handling.
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccDataSourceAwsVpc_basic (27.54s)
    --- PASS: TestAccDataSourceAwsVpc_ipv6Associated (27.56s)
    --- PASS: TestAccDataSourceAwsVpc_multipleCidr (51.12s)
    ```
    bflad authored Oct 25, 2019
    Configuration menu
    Copy the full SHA
    0996270 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #10313 from terraform-providers/d-provider-tagging

    docs/provider: Add Adding Resource Tagging Support section
    bflad authored Oct 25, 2019
    Configuration menu
    Copy the full SHA
    ef3fddc View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    9c9f323 View commit details
    Browse the repository at this point in the history
  13. Merge pull request #10638 from terraform-providers/renovate/github.co…

    …m-hashicorp-terraform-plugin-sdk-1.x
    
    Update module hashicorp/terraform-plugin-sdk to v1.2.0
    bflad authored Oct 25, 2019
    Configuration menu
    Copy the full SHA
    e2553d8 View commit details
    Browse the repository at this point in the history