Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin.xml #146

Closed
wants to merge 1 commit into from
Closed

Update plugin.xml #146

wants to merge 1 commit into from

Conversation

Bratt-ec
Copy link

@Bratt-ec Bratt-ec commented Nov 25, 2021

Add mode="overwrite" in config file
Add android:exported="true" in two services: com.adobe.phonegap.push.FCMService , com.adobe.phonegap.push.PushInstanceIDListenerService

Description

Added android:exported="true" as these are required in cordova 10.
Added mode="overwrite" to avoid duplication of these attributes in AndroidManifest.xml

Motivation and Context

In the development of an application I encountered this pair of problems, and since it has not been corrected, I thought I would contribute with this solution

How Has This Been Tested?

The proposed changes were tested in applications that are in production today and work correctly.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • All new and existing tests passed.

Add mode="overwrite" in config file
Add android:exported="true" in two services: com.adobe.phonegap.push.FCMService , com.adobe.phonegap.push.PushInstanceIDListenerService
@Ruud-cb
Copy link

Ruud-cb commented Dec 23, 2021

Looking forward to the merge of this and a hotfix release as this currently prevents us from targeting sdk 31 which other plugins require. Although is similar to #153 which also has more chnges.

@erisu
Copy link

erisu commented Feb 26, 2022

Adding mode="overwrite" to config-file shouldn't have any point or action.

From the Cordova documentation, the mode attribute only exists on the edit-config element, not the config-file element.

In this patch, is it OK if you can remove the mode="overwrite" so we can merge in only the android:exported flags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants