fix(android): add service exported flags w/ intent-filter #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dertieran
pushed a commit
to dertieran/cordova-plugin-push
that referenced
this pull request
Sep 22, 2022
lempere
pushed a commit
to we-are-Joinup/cordova-plugin-push
that referenced
this pull request
Oct 28, 2022
lempere
pushed a commit
to we-are-Joinup/cordova-plugin-push
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added missing
android:exported="true"flags for services that hasintent-filter.Related Issue
closes: #146
closes: #153
Motivation and Context
Follow documentation sepc: https://developer.android.com/guide/topics/manifest/service-element#exported
How Has This Been Tested?
cordova build androidcordova run androidScreenshots (if appropriate):
Types of changes
Checklist: