Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added android:exported=true in service tag as in Android 11 its compu… #153

Closed
wants to merge 20 commits into from

Conversation

sparkwork992
Copy link

@sparkwork992 sparkwork992 commented Dec 20, 2021

…lsory to have this tag if intent-filter is used

Description

We need to have android:exported="true" tag in services also if we are using intent-filter. This is required in Android 11 + builds.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Ruud-cb
Copy link

Ruud-cb commented Dec 23, 2021

Looking forward to the merge of this and a hotfix release as this currently prevents us from targeting sdk 31 which other plugins require.

@Ruud-cb Ruud-cb mentioned this pull request Dec 23, 2021
2 tasks
@erisu erisu closed this in #173 Mar 12, 2022
@erisu
Copy link

erisu commented Mar 12, 2022

The changes in this PR is more then what the title and description talks about.
A single PR should focus on an individual bug or feature. Not a collection of changes.

I created a PR and commited into master the changes that this PR's title and description is targeting.
If the other changes are required, split them out please into seperate PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants