Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Spring EVERYWHERE. #818

Closed
schneems opened this issue Oct 5, 2018 · 4 comments
Closed

Disable Spring EVERYWHERE. #818

schneems opened this issue Oct 5, 2018 · 4 comments

Comments

@schneems
Copy link
Contributor

schneems commented Oct 5, 2018

I've gotten a few tickets that were resolved by disabling spring with DISABLE_SPRING=1. We should consider setting this as a default env var for CI.
@schneems
Copy link
Contributor Author

schneems commented Oct 5, 2018

Internal ticket ID 631486

@stormsilver
Copy link

One example of what disabling Spring solves is when the app is running a different version of Ruby than what the buildpack installs for its own execution.

For example, as of today the buildpack installs Ruby 2.5.3 to execute itself, but my app uses Ruby 2.6.1. The buildpack correctly installs 2.6.1, but when it arrives at the test phase it complains that I'm running a different version of Ruby than my Gemfile specifies. This happens to be true because Spring has helpfully cached the process for us. Disabling Spring allowed the test phase to fire up the proper version of Ruby.

@schneems schneems changed the title Disable Spring on CI? Disable Spring EVERYWHERE. May 14, 2019
@schneems
Copy link
Contributor Author

Thanks for the feedback @stormsilver.

Another issue that I saw recently is found in internal ticket id 712875

@schneems
Copy link
Contributor Author

schneems commented Jun 4, 2020

Ticket https://heroku.support/881089

schneems added a commit that referenced this issue Jun 10, 2020
@schneems
Merge pull request #1017 from heroku/schneems/disable-spring
30184b6 
[close #818] Disable spring
krisrang added a commit to skyltmax/heroku-buildpack-ruby that referenced this issue Oct 2, 2020
@krisrang
Merge remote-tracking branch 'upstream/master'
a3bc77a 
* upstream/master:
  [changelog skip] Bring back rake task (heroku#1038)
  CNB: make the gems layer accessible to subsequent buildpacks heroku#1033  (heroku#1037)
  [close heroku#934] Skip rake task if it does not exist (heroku#1036)
  [changelog skip] Move unreleased changelogs (heroku#1035)
  v218 for Monday release (heroku#1034)
  [close heroku#1029] Remove default bin/rake binstub (heroku#1031)
  Document v217 release in master (heroku#1030)
  [close heroku#1027][changelog skip] Fix frozen string error (heroku#1028)
  Handle binary binstubs (heroku#1021)
  v216 release for monday (heroku#1023)
  Revert "Merge pull request heroku#1014 from heroku/schneems/fu-binstubs"
  [close heroku#990] Warn on bad shebang line
  [close heroku#818] Disable spring
  [changelog skip][close heroku#977] Recommend recent Ruby in warning
  [changelog skip][close heroku#977] Recommend recent Ruby in warning
  [close heroku#1001] Put Yarn first on the path
  Update HEREDOC to 2.5 syntax to support indenting
  Switch to using /usr/bin/env bash
  [changelog skip] Fix CNB tests
  Allow Nolockfile to get to compile phase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schneems @stormsilver