[close #990] Warn on bad shebang line #1014
Conversation
schneems
force-pushed
the
schneems/fu-binstubs
branch
from
204f921 to
6a1ebc4
Compare
There was a problem hiding this comment.
Do we know if it's also common for users to hardcode system ruby paths in their shebangs (ie not using /usr/bin/env)?
Separately, I wonder if longer term we need metrics for usage of some of the warning features (such as this or the bundler warnings) to see when the issues are no longer occurring (eg due to ecosystem changes) - allowing older buildpack functionality to be gradually retired/simplified?
In all the tickets i've seen about this, I've never found one that's not
The "right" thing to do here would be to throw all warnings into honeycomb via |
|
I could swear I read a great page on either Bundler.io or RubyGems.org the other day that explained exactly why this happens (short version: history). But for the life of me I can't find it anymore. |
This article explains binstubs and "shebang" lines: https://devcenter.heroku.com/articles/bad-ruby-binstub-shebang. A relatively common problem when generating a binstub is for it to contain a bad shebang line. Here's an example: ``` #!/usr/bin/env ruby2.5 ``` If you've got a binstub with that shebang line in your project and are running on Heroku 18 then your app will be forced to use `ruby2.5` binary no matter what version of Ruby you've specified in the `Gemfile`. This causes very odd behavior and weird, difficult to debug bundler errors. This PR does not fix the problem, but will at least warn anyone with a version number in their ruby shebang line. This behavior was originally: - Introduced: #586 - Rolled back: #623 It was rolled back because it would falsely claim that `#!/usr/bin/env bash` was incorrect also it only protected against a limited set of binstubs.
schneems
force-pushed
the
schneems/fu-binstubs
branch
from
6a1ebc4 to
6499ce8
Compare
I've seen this one https://bundler.io/man/bundle-binstubs.1.html. Not sure if there was another you're referencing. Binstubs are great for solving the |
|
Eh, no, turns out I was thinking of this similar-but-different issue: https://bundler.io/blog/2019/05/14/solutions-for-cant-find-gem-bundler-with-executable-bundle.html which your buildpack already works around.
--- original message ---
On June 10, 2020, 4:05 PM EDT ***@***.*** wrote:
I could swear I read a great page on either Bundler.io
I've seen this one https://bundler.io/man/bundle-binstubs.1.html. Not sure if there was another you're referencing. Binstubs are great for solving the bundle exec problem...provided they don't have bugs in them.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
--- end of original message ---
|
This reverts commit aeed0ce, reversing changes made to 30184b6. Due to ticket https://heroku.support/885880 Error is: ``` ! ! invalid byte sequence in UTF-8 ! /app/tmp/buildpacks/dir/lib/language_pack/helpers/binstub_check.rb:27:in match?': invalid byte sequence in UTF-8 (ArgumentError) from /app/tmp/buildpacks ```
Revert "Merge pull request #1014 from heroku/schneems/fu-binstubs"
|
I had to revert this in #1020 |
* upstream/master: [changelog skip] Bring back rake task (heroku#1038) CNB: make the gems layer accessible to subsequent buildpacks heroku#1033 (heroku#1037) [close heroku#934] Skip rake task if it does not exist (heroku#1036) [changelog skip] Move unreleased changelogs (heroku#1035) v218 for Monday release (heroku#1034) [close heroku#1029] Remove default bin/rake binstub (heroku#1031) Document v217 release in master (heroku#1030) [close heroku#1027][changelog skip] Fix frozen string error (heroku#1028) Handle binary binstubs (heroku#1021) v216 release for monday (heroku#1023) Revert "Merge pull request heroku#1014 from heroku/schneems/fu-binstubs" [close heroku#990] Warn on bad shebang line [close heroku#818] Disable spring [changelog skip][close heroku#977] Recommend recent Ruby in warning [changelog skip][close heroku#977] Recommend recent Ruby in warning [close heroku#1001] Put Yarn first on the path Update HEREDOC to 2.5 syntax to support indenting Switch to using /usr/bin/env bash [changelog skip] Fix CNB tests Allow Nolockfile to get to compile phase
This article explains binstubs and "shebang" lines: https://devcenter.heroku.com/articles/bad-ruby-binstub-shebang. A relatively common problem when generating a binstub is for it to contain a bad shebang line. Here's an example:
If you've got a binstub with that shebang line in your project and are running on Heroku 18 then your app will be forced to use
ruby2.5binary no matter what version of Ruby you've specified in theGemfile. This causes very odd behavior and weird, difficult to debug bundler errors.This PR does not fix the problem, but will at least warn anyone with a version number in their ruby shebang line.
This behavior was originally:
It was rolled back because it would falsely claim that
#!/usr/bin/env bashwas incorrect also it only protected against a limited set of binstubs.