CNB: make the gems layer accessible to subsequent buildpacks #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR I'm running tests (plus added a test for this behavior) in #1037 |
schneems
added a commit
that referenced
this pull request
Jul 16, 2020
|
thanks for the PR I merged my test of your code in! |
|
Thank you, @schneems! |
krisrang
added a commit
to skyltmax/heroku-buildpack-ruby
that referenced
this pull request
Oct 2, 2020
* upstream/master: [changelog skip] Bring back rake task (heroku#1038) CNB: make the gems layer accessible to subsequent buildpacks heroku#1033 (heroku#1037) [close heroku#934] Skip rake task if it does not exist (heroku#1036) [changelog skip] Move unreleased changelogs (heroku#1035) v218 for Monday release (heroku#1034) [close heroku#1029] Remove default bin/rake binstub (heroku#1031) Document v217 release in master (heroku#1030) [close heroku#1027][changelog skip] Fix frozen string error (heroku#1028) Handle binary binstubs (heroku#1021) v216 release for monday (heroku#1023) Revert "Merge pull request heroku#1014 from heroku/schneems/fu-binstubs" [close heroku#990] Warn on bad shebang line [close heroku#818] Disable spring [changelog skip][close heroku#977] Recommend recent Ruby in warning [changelog skip][close heroku#977] Recommend recent Ruby in warning [close heroku#1001] Put Yarn first on the path Update HEREDOC to 2.5 syntax to support indenting Switch to using /usr/bin/env bash [changelog skip] Fix CNB tests Allow Nolockfile to get to compile phase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gemslayer writes a couple of environment variables to#{layer.path}/env.build(ref 1, ref 2) but because thebuildoption is not set on the layer, these environment variables are not made accessible to subsequent buildpacks.This sets
build: trueon thegemslayer to correct that.