Add configurable intervals to device tracker.

[andythigpen]

Allows the user to configure a longer interval for when the device tracker should scan for devices.

If there's a better way to do this, let me know and I can update it. Thanks for the great project. I hope to contribute more in the future.

[balloob]

Thanks for all your contributions!

Could you in the future target the dev branch instead of master with your pull requests?

This seems like the right way to do it. You might want to get rid of the hours and minutes, it doesn't sound like anyone would ever pick such a big interval.

There also seem to be some style violations reported by Travis.

[andythigpen]

Thanks. That's a good point. In the future, I was thinking of trying to
implement variable intervals based on if any devices were home or not. My
thought was that pinging my phone every 12 seconds would keep the radio on
and drain the battery, so instead while I'm home the interval would
increase to several minutes and while I'm away it could drop back down to
every 12 seconds. It may not be worth it to try to implement this though,
since I've been using it for awhile and haven't noticed a significant
difference in battery life.

I'll clean this up and send a new pull request to the dev branch.

Thanks again!
On Feb 21, 2015 6:24 PM, "Paulus Schoutsen" notifications@github.com
wrote:

Thanks for all your contributions!

Could you in the future target the dev branch instead of master with your
pull requests?

This seems like the right way to do it. You might want to get rid of the
hours and minutes, it doesn't sound like anyone would ever pick such a big
interval.

There also seem to be some style violations reported by Travis
https://travis-ci.org/balloob/home-assistant/builds/51674368#L553.

—
Reply to this email directly or view it on GitHub
#36 (comment).

[balloob]

I like the idea of lowering the scan interval. It should only do that when all track devices are home otherwise it might be late on firing a coming home event for someone.

[coveralls]

Coverage increased (+0.07%) to 53.76% when pulling 171acfda707441e778c24a9cb9305693eea032c9 on andythigpen:feature/device-tracker-interval into b5a3a72 on balloob:master.

[andythigpen]

I noticed that you gave me commit access to your repository. Are there guidelines for branching, merging, etc. that I should follow? Would you like me to still submit pull requests so that you can review my code?

I wanted to check with you first before just committing something.

[balloob]

Trying out something I read.

Would be great if you still use pull request for the big features. Small bug fixes is fine to commit to dev directly. I'll try to extend the contributing guide lines this week - never gave it much thought.

[balloob]

You can pass in 12 here as the third argument to have it return in case of an error. (instead of line 132-133). For readability might even be better to add DEFAULT_CONF_SECONDS = 12 to the top of the page.

[coveralls]

Coverage increased (+0.06%) to 53.75% when pulling 22a2b65 on andythigpen:feature/device-tracker-interval into b5a3a72 on balloob:master.

[balloob]

andythigpen added a commit 2 days ago <- looks like your date is off!

[andythigpen]

Haha. I think that's because I was just amending my original commit. That's probably not the best way to do it, I guess!