-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add baseDir option, add -b flag to cli options to specify base path #294
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Rebased in case this becomes mergeable - @indexzero LMK if I should keep this branch in sync or if we should close this PR, thanks! |
This is the same as #395 - hope the feature is available soon. |
This comment has been minimized.
This comment has been minimized.
This needs rebasing on top of the latest from If someone wants to get this up to speed with the latest from master, I'm 👍 on merging it. |
All set. Noticed the paths weren't printing to the logs, so I added that too. |
@BigBlueHat yeah that makes sense, 'b' is a popular letter. Brotli can be |
Alright, @idmontie's #395 and @jesseditson's #294 have a one-line difference. I'm going to go with #294 because it came first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This branch is a bit behind master, and there are a few change still scheduled (like #131) which will happen before this PR merges
I'll fix this up tonight (PST) and rebase against master! |
Ok I think this is up to date, LMK if there's anything else needed on my end! |
Would it be possible to split the change into
The implementation seams ready and the functionality is requested ( see #139 ) since years. |
Is this PR going to be merged any time soon? Would love to be able to use this functionality. |
Oh, please, is there any way one can help to get this merged? |
Requirements for merging:
|
This has long fallen off of my radar (I filed this PR 5 years ago and no longer have a dependency on this lib), happy to fix conflicts if a different interested party wants to get the docs going. |
Is this still an open feature? I was trying to implement |
@thornjad @jesseditson |
Can this be merged? We do need this feature. Thanks! |
Merged #837 because it was more recent (less conflicts) and had fewer whitespace-only changes. |
node-ecstatic allows for a
baseDir
option, which I was looking to use with this lib.This PR adds the following:
baseDir
option to the main lib file-b
flag to the cli toolpath
variable to printed/opened URLsFixes #139