Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --base-dir to cli options to specify base path #837

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

MaximSagan
Copy link
Contributor

Rebased and update stale PR #294.
Fixes #139.

@Galileon-venta
Copy link

Is @thornjad the only one to merge on this project? Is there any realistic ETA for this to be contained in a new release?

@MaximSagan
Copy link
Contributor Author

Is @thornjad the only one to merge on this project? Is there any realistic ETA for this to be contained in a new release?

Yep, it's only @thornjad, and unfortunately he seems to have largely abandoned this project.

@cmoesel
Copy link

cmoesel commented Sep 22, 2023

In case anyone is still keeping track, I'd love to see this feature merged in.

Copy link

This pull request has been inactive for 360 days

@github-actions github-actions bot added the stale label Sep 17, 2024
@KernelDeimos
Copy link
Contributor

Preferring this over #294 because this is more recent and has fewer whitespace-only changes

@KernelDeimos
Copy link
Contributor

I forgot GH would do a merge commit instead of rebasing when I did that... gross

@KernelDeimos
Copy link
Contributor

The tests which didn't pass appear to be due to a race condition on port conflicts for test servers, so I'm considering this good to go - going to merge and re-test.

@KernelDeimos KernelDeimos merged commit fe91590 into http-party:master Nov 5, 2024
10 of 15 checks passed
@kirill-konshin
Copy link

Looks like this PR has been merged, but there's no release, what is the likelihood that will be released any time soon?

@MaximSagan MaximSagan deleted the base_path branch December 23, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serve multiple directories
6 participants